Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-802] Added config setting for getting notification for draft PRs #804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GH-802] Added config setting for getting notification for draft PRs #804

wants to merge 1 commit into from

Conversation

raghavaggarwal2308
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 commented Jul 15, 2024 •
edited
Loading

Summary

  • Added config setting for getting notification for draft PRs
  • Add config setting to make the changes from this PR configurable.

Screenshot:

image

What to test:

  1. When setting is disabled:
  • Getting a single for notification regardless of the PR state (i.e. draft/ready).
  1. When setting is enable:
  • Getting a notification with less details when a draft PR is created.
  • Getting a notification with complete details when a draft PR is marked as ready for review.
  • Getting a notification with complete details for a normal PR.

How to test:

  1. Connect you github account.
  2. Create subscription for "pulls" in desired channel
  3. Trigger the desired event from github.

Ticket Link

Fixes #802

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Jul 15, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v2.4.0 milestone Jul 15, 2024
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jul 31, 2024
@raghavaggarwal2308 raghavaggarwal2308 added the 3: QA Review Requires review by a QA tester label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@wiggin77 wiggin77 Awaiting requested review from wiggin77 wiggin77 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@raghavaggarwal2308 raghavaggarwal2308

Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Make the new Draft PR behavior configurable
3 participants
@raghavaggarwal2308 @ayusht2810 @hanzei