Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-517]: Fixed the issue 'Unable to subscribe to groups or subgroups #518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MM-517]: Fixed the issue 'Unable to subscribe to groups or subgroups #518

wants to merge 1 commit into from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Aug 20, 2024 •
edited
Loading

Summary

  1. Added the condition that the permission to the project will only be checked if the subscription to be created is of project-level subscription.
  2. Permission for the group and sub-group is already getting checked in the ResolveNamespaceAndProject function.

Ticket Link

Fixes #517

Testing Steps

  1. Create a group, sub-group, and project subscriptions.

@Kshitij-Katiyar Kshitij-Katiyar changed the title [MM-517]: Fixed the issue #517 'Unable to subscribe to groups or subgroups [MM-517]: Fixed the issue 'Unable to subscribe to groups or subgroups Aug 20, 2024
@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@spirosoik spirosoik Awaiting requested review from spirosoik spirosoik is a code owner

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.9.1] Unable to subscribe to groups or subgroups
3 participants
@Kshitij-Katiyar @wiggin77 @raghavaggarwal2308