Include more fields in Create Issue modal #583

mickmister · 2020-06-08T10:05:22Z

Summary

You can now use every applicable Jira field in the Create Issue modal. Basically all of them except date pickers.

Ticket Link

Fixes #563
Fixes #520
Fixes #394
Fixes #471
Fixes #502

The client go-jira client library used doesn't implement label search. This means changes had to be made to the GetClient method on Jira Instance interface to also return http.Client that is configured and sent to NewClient method of the go-jira library. Delete console.log statement Clean up code Remove unused go package and update webapp snaps Use RESTGet in GetLabels Remove unnecessary function arg, url Make autocomplete search more generic Fix a comparison error Make front end autocomplete components generic

codecov-commenter · 2020-06-08T10:05:27Z

Codecov Report

Merging #583 into master will decrease coverage by 0.49%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   34.50%   34.00%   -0.50%     
==========================================
  Files          51       52       +1     
  Lines        5684     5766      +82     
==========================================
  Hits         1961     1961              
- Misses       3530     3612      +82     
  Partials      193      193

Impacted Files	Coverage Δ
server/autocomplete_search.go	`0.00% <0.00%> (ø)`
server/client.go	`8.54% <0.00%> (-0.67%)`	⬇️
server/client_cloud.go	`0.00% <0.00%> (ø)`
server/client_server.go	`0.00% <0.00%> (ø)`
server/http.go	`27.31% <0.00%> (-0.52%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf30c36...e1d9015. Read the comment docs.

larkox

Some small change proposals.

server/client.go

webapp/src/actions/index.js

webapp/src/components/data_selectors/jira_autocomplete_selector/jira_autocomplete_selector.tsx

- handle case where changing issue type or project causes invalid fields to be filled out - handle clearing a single select value properly

…labels

mickmister · 2020-07-10T21:18:35Z

@jfrerich This is ready for review

mickmister · 2020-07-10T21:27:25Z

Most of the diff is due to snapshots that contain the Jira issue metadata as a prop passing to several children. Looking at the jest testing docs and forums, it doesn't seem like this is avoidable unless we get rid of the snapshot tests.

DHaussermann · 2020-09-28T20:15:40Z

@mickmister issue 2B. occurs on Cloud only. I can create a separate issue for this. It was not introduced by this PR. I see it on Jira v3.0.0 Version bump branch.

mickmister · 2020-09-29T19:32:51Z

@DHaussermann Do you know which bugs that were introduced in this PR that must be addressed here?

DHaussermann · 2020-10-08T20:29:32Z

@mickmister I've taken another look at the issues here:

1. Post text is not added to issue description when the modal opens --> seems resolved

2A. Not all missing mandatory fields missing are shown on the bullet list in Mattermost post along with the link. It will only show one of them. --> seems introduced here does not repro on the 3.0.0 release

2B. Reporter is missing --> Not new. Separate issue opened

2C. Some of the fields I passed in via the modal are not shown in the Jira UI when I go to finish saving the issue but the rest are there. --> This seems only applicable to this PR. I see it with Components, Fix version, label, Checkboxes (not an exhaustive list) which are all fields where it was previously not possible to attempt and set them in the modal

Reach out if you'd like to discuss this.

DHaussermann · 2020-11-18T16:18:40Z

/update-branch

mattermod · 2020-11-18T16:18:42Z

Error trying to update the PR.
Please do it manually.

…ee-and-labels

codecov-io · 2021-01-26T15:49:27Z

Codecov Report

Merging #583 (3c91261) into master (c8ab47b) will decrease coverage by 0.45%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   32.38%   31.92%   -0.46%     
==========================================
  Files          52       53       +1     
  Lines        5361     5437      +76     
==========================================
  Hits         1736     1736              
- Misses       3423     3499      +76     
  Partials      202      202

Impacted Files	Coverage Δ
server/autocomplete_search.go	`0.00% <0.00%> (ø)`
server/client.go	`9.17% <0.00%> (-0.72%)`	⬇️
server/client_cloud.go	`0.00% <0.00%> (ø)`
server/client_server.go	`0.00% <0.00%> (ø)`
server/http.go	`25.83% <0.00%> (-0.51%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ab47b...3c91261. Read the comment docs.

mattermod · 2021-02-06T01:01:05Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

mickmister · 2021-03-30T06:17:54Z

@mickmister I've taken another look at the issues here:

1. Post text is not added to issue description when the modal opens --> seems resolved

2A. Not all missing mandatory fields missing are shown on the bullet list in Mattermost post along with the link. It will only show one of them. --> seems introduced here does not repro on the 3.0.0 release

2B. Reporter is missing --> Not new. Separate issue opened

2C. Some of the fields I passed in via the modal are not shown in the Jira UI when I go to finish saving the issue but the rest are there. --> This seems only applicable to this PR. I see it with Components, Fix version, label, Checkboxes (not an exhaustive list) which are all fields where it was previously not possible to attempt and set them in the modal

Reach out if you'd like to discuss this.

@DHaussermann I think I need to use your Jira setup to reproduce 2a. and 2c.

DHaussermann · 2021-08-16T18:10:37Z

Reviewed this PR with @mickmister

Of the issues above - all have been resolved except 2C Some of the fields I passed in via the modal are not shown in the Jira UI when I go to finish saving the issue.
Created a separate issue here Data missing from Jira issue when unsupported custom fields are mandatory #794 to address 2C
It was also noticed that Epic Link does not appear in the modal. This should be resolved in this pr

codecov-commenter · 2021-08-16T18:12:55Z

Codecov Report

Merging #583 (1e72633) into master (16e0e5c) will decrease coverage by 0.45%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   35.16%   34.70%   -0.46%     
==========================================
  Files          51       52       +1     
  Lines        5827     5909      +82     
==========================================
+ Hits         2049     2051       +2     
- Misses       3573     3653      +80     
  Partials      205      205

Impacted Files	Coverage Δ
server/autocomplete_search.go	`0.00% <0.00%> (ø)`
server/client.go	`8.93% <0.00%> (-0.70%)`	⬇️
server/client_cloud.go	`0.00% <0.00%> (ø)`
server/client_server.go	`0.00% <0.00%> (ø)`
server/http.go	`40.13% <0.00%> (-1.09%)`	⬇️
server/subscribe.go	`67.48% <0.00%> (+0.37%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16e0e5c...1e72633. Read the comment docs.

DHaussermann · 2021-08-16T20:50:48Z

/update-branch

DHaussermann

Tested and passed

Working on Cloud and server instances as per previous testing
Epic Link is now functional on both Cloud and server
Failing snapshots are now esoved
Created Data missing from Jira issue when unsupported custom fields are mandatory #794 to address the remaining issue in a separate PR

LGTM! please merge

mickmister and others added 5 commits June 8, 2020 03:59

Extract backend_selector

cda7c49

label selector works in create issue modal

c0159b6

include custom labels and user pickers

256b14f

include custom labels in subscribe modal

7f0e658

mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 8, 2020

mickmister requested review from larkox and jfrerich June 8, 2020 10:05

fix tests

3c66e0e

larkox requested changes Jun 9, 2020

View reviewed changes

server/client.go Outdated Show resolved Hide resolved

webapp/src/actions/index.js Outdated Show resolved Hide resolved

webapp/src/components/data_selectors/jira_autocomplete_selector/jira_autocomplete_selector.tsx Outdated Show resolved Hide resolved

mickmister marked this pull request as draft July 1, 2020 16:44

mickmister added 9 commits July 7, 2020 03:25

clean up test

c11df52

Use assignee search for user search

833948f

Support other misc fields

426e44d

fix some bugs:

7c35283

- handle case where changing issue type or project causes invalid fields to be filled out - handle clearing a single select value properly

fix tests

7b48d64

PR feedback

fde3069

Merge branch 'master' into create-issue-assignee-and-labels

a0f881e

Merge branch 'create-issue-epic-link' into create-issue-assignee-and-…

4b64db4

…labels

fix lint

b480395

mickmister marked this pull request as ready for review July 10, 2020 21:17

mickmister requested a review from larkox July 10, 2020 21:18

mickmister changed the base branch from create-issue-epic-link to master July 10, 2020 21:25

mickmister changed the title ~~Include Assignee and Label pickers in Create Issue modal~~ Include more fields in Create Issue modal Jul 10, 2020

mickmister added 2 commits July 10, 2020 17:28

type lint

97264e5

run snapshots again due to mattermost-redux dep from master

8a6eb97

Merge remote-tracking branch 'origin/master' into create-issue-assign…

358de35

…ee-and-labels

mattermod added the Lifecycle/1:stale label Feb 6, 2021

emilyacook removed the Lifecycle/1:stale label Feb 11, 2021

mickmister added 2 commits March 30, 2021 00:34

Merge branch 'master' into create-issue-assignee-and-labels

a42052c

type improvements

3c91261

mickmister removed this from the v3.1.0 milestone Apr 26, 2021

mickmister mentioned this pull request Jul 2, 2021

Support filtering on comment visibility for subscriptions #626

Open

DHaussermann added this to the v3.1.0 milestone Jul 19, 2021

add epic link to supported fields

e3ddfa9

change import order

1dafa63

mattermod and others added 2 commits August 16, 2021 22:50

Merge branch 'master' into create-issue-assignee-and-labels

bd903bf

update snapshot

1e72633

DHaussermann approved these changes Aug 17, 2021

View reviewed changes

DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 17, 2021

mickmister merged commit 99a8136 into master Aug 17, 2021

mickmister deleted the create-issue-assignee-and-labels branch August 17, 2021 15:54

mickmister mentioned this pull request Sep 8, 2021

Bump to version 3.1.0 #800

Merged

mickmister mentioned this pull request Jan 24, 2023

[GH-830]: Explained the jira subscription modal in the doc #904

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include more fields in Create Issue modal #583

Include more fields in Create Issue modal #583

mickmister commented Jun 8, 2020 •

edited by hanzei

Loading

codecov-commenter commented Jun 8, 2020 •

edited

Loading

larkox left a comment

mickmister commented Jul 10, 2020

mickmister commented Jul 10, 2020

DHaussermann commented Sep 28, 2020

mickmister commented Sep 29, 2020

DHaussermann commented Oct 8, 2020 •

edited

Loading

DHaussermann commented Nov 18, 2020

mattermod commented Nov 18, 2020

codecov-io commented Jan 26, 2021 •

edited

Loading

mattermod commented Feb 6, 2021

mickmister commented Mar 30, 2021

DHaussermann commented Aug 16, 2021

codecov-commenter commented Aug 16, 2021 •

edited

Loading

DHaussermann commented Aug 16, 2021

DHaussermann left a comment

Include more fields in Create Issue modal #583

Include more fields in Create Issue modal #583

Conversation

mickmister commented Jun 8, 2020 • edited by hanzei Loading

Summary

Ticket Link

codecov-commenter commented Jun 8, 2020 • edited Loading

Codecov Report

larkox left a comment

Choose a reason for hiding this comment

mickmister commented Jul 10, 2020

mickmister commented Jul 10, 2020

DHaussermann commented Sep 28, 2020

mickmister commented Sep 29, 2020

DHaussermann commented Oct 8, 2020 • edited Loading

DHaussermann commented Nov 18, 2020

mattermod commented Nov 18, 2020

codecov-io commented Jan 26, 2021 • edited Loading

Codecov Report

mattermod commented Feb 6, 2021

mickmister commented Mar 30, 2021

DHaussermann commented Aug 16, 2021

codecov-commenter commented Aug 16, 2021 • edited Loading

Codecov Report

DHaussermann commented Aug 16, 2021

DHaussermann left a comment

Choose a reason for hiding this comment

mickmister commented Jun 8, 2020 •

edited by hanzei

Loading

codecov-commenter commented Jun 8, 2020 •

edited

Loading

DHaussermann commented Oct 8, 2020 •

edited

Loading

codecov-io commented Jan 26, 2021 •

edited

Loading

codecov-commenter commented Aug 16, 2021 •

edited

Loading