[GH-774] Add tooltip to Jira ticket links #887
Conversation
There was a problem hiding this comment.
Just some non-blocking comments. LGTM 🎉 Thanks for this awesome improvement @raghavaggarwal2308!
webapp/src/components/jira_ticket_tooltip/jira_ticket_tooltip.tsx
Outdated
Show resolved
Hide resolved
webapp/src/components/jira_ticket_tooltip/jira_ticket_tooltip.tsx
Outdated
Show resolved
Hide resolved
[MI-3103] Review fixes on Jira PR mattermost#887 (Add link tooltip)
|
@mickmister Fixed the review comments mentioned by you |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
|
@DHaussermann Gentle reminder for review |
2 similar comments
|
@DHaussermann Gentle reminder for review |
|
@DHaussermann Gentle reminder for review |
|
@AayushChaudhary0001 Would you be open on reviewing this PR? |
There was a problem hiding this comment.
Tested this PR.
@raghavaggarwal2308 I am facing an issue that the tooltip is not getting rendered and undergoing loading state for a very long period.
|
@AayushChaudhary0001 Can you please provide any information from the dev tools console, and relevant network tab requests? You can filter the Jira plugin requests like this, then copy any context available in the "Preview" tab of the response
Also check the "Console" tab of the dev tools, to see if there are any errors that contain the word "jira" in the error's file path |
|
@mickmister The branch on @AayushChaudhary0001 local was not updated with the latest changes. The issue is fixed now. Sorry for the trouble. |
|
Tested and approved, LGTM. |
hanzei
added
4: Reviews Complete
… url (#870) * [MI-2154]:Fixed issue(768) /Jira Connect doesn't open mattermost's subpath url (#3) * Fixes #768 * Update webapp/src/actions/index.ts updated the url to use string interpolation syntax. Co-authored-by: Michael Kochell <[email protected]> * updated with feedback from Michael * removed the unwanted styles changes * removed the unwanted styles changes * removed the unwanted styles changes * resolved comments * resolved comments * plugin now adds the entire url from the config * connect to cloud with subpath now working * fixed styling and linting issues * fixed linting issue * Update server/user_cloud.go Co-authored-by: Michael Kochell <[email protected]> * updated method to call the site url with a sub path * updated method to call the site url with a sub path * updated logic based on lev's comments * added a method in plugin.go that will generate the final path * updated based on feedback from levb * added method to generate full path * fixed conflicts * updated and tested connect * Update index.ts removed whitespace * Update webpack.config.js * updated SiteURL handler * [MI-2154]:fixed lint errors * [MI-2154]:fixed review fixes Co-authored-by: Sanjay <sanjaymj@12345> Co-authored-by: Maisnam Raju Singh <[email protected]> Co-authored-by: Michael Kochell <[email protected]> Co-authored-by: maisnamrajusingh <[email protected]> * [MM-768]:fixed CI error * Improved code quality (#5) * Review fixes done * [MI-2182]: Review fixes done 1. Improved code quality * [MI:2182]:Review fixes done 1.Improved code quality * Review fixes done of #870 (#13) * Review fixes done * [MI-2182]: Review fixes done 1. Improved code quality * [MI:2182]:Review fixes done 1.Improved code quality * [MI-2182]: Review fixes done 1.Improved code quality * [MI-2182]:Fixed CI errors * [MM-768]:Fixed review comment * [MI-2839]: Done the review fixes of a Jira PR #870 (#41) * [MI-2839]: Done the review fixes of a Jira PR #887 * [MI-2839]: Review fixes done 1.Changed the way to create a full URL path --------- Co-authored-by: Sanjay <sanjaymj@12345> Co-authored-by: Maisnam Raju Singh <[email protected]> Co-authored-by: Michael Kochell <[email protected]> Co-authored-by: maisnamrajusingh <[email protected]> Co-authored-by: Nityanand Rai <[email protected]> Co-authored-by: Nityanand Rai <[email protected]> Co-authored-by: raghavaggarwal2308 <[email protected]>
Summary
Most of the code here is from #835. The person who created #835 PR was not responding for a while. So, we recreated the same PR with the typescript errors and some bugs fixed.
Changes made-
Screenshots
Ticket
Fixes #774 (Add tooltip to Jira ticket links)