server: never give up on trying #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At a high level, wondering if we should start by adding more logging and simply try to understand what's happening. Or perhaps try to repro this on a spinwick. Did the existing logs from community shed any light? Retrying continuously seems like trying to throw something and see what works. If possible, I'd prefer a methodical approach to this. |
|
Removing myself until there's more activity on this. |
|
Closing this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While testing the plugin on community, I came across to several occurrences of plugin not starting to scraping after a node restart. It may be a case if the lock is not being acquired. The goal of this PR is to improve logging and let plugins try to acquire the lock continuously. The attempt will be done in 60 seconds so it's not a big deal.