Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup server code that is not needed in product mode #1829

Open
4 of 6 tasks
trilopin opened this issue Feb 28, 2023 · 1 comment
Open
4 of 6 tasks

Cleanup server code that is not needed in product mode #1829

trilopin opened this issue Feb 28, 2023 · 1 comment
Assignees

Comments

@trilopin
Copy link
Contributor

trilopin commented Feb 28, 2023

Files to be checked:

  • server/manifest.go
  • main.go
  • Check e2e server test, are plugin complexities needed?

Remove comments, finish migration:

  • main_test.go

Improve naming:

  • server/sqlstore/pluginapi_client -> not pluginapi anymore but serviceapi
  • product/pluginapi -> not pluginapi anymore, is that name needed?
@trilopin trilopin converted this from a draft issue Feb 28, 2023
@trilopin trilopin self-assigned this Feb 28, 2023
@trilopin trilopin mentioned this issue Feb 28, 2023
3 tasks
@trilopin
Copy link
Contributor Author

trilopin commented Mar 1, 2023

@lieut-data I've skipped the pluginapi rename. There're lots of pluginapi package and field names that don't really match with the old pluginApi.

It needs more care but can be done after monorepo merge (so we don't block other prs etc...).

@trilopin trilopin moved this from In Progress to Done in MPA & Monorepo Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant