Mpa playbooks cleanup #1824
Merged
Mpa playbooks cleanup #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trilopin, I took the liberty of merging upstream with your branch and running the e2e tests: they all pass!
|
|
Should we rip out the use of |
* mpa-playbooks: Copy web app's eslint-disable for webpack.config.js Fix styling Switch from https to server for configuring dev server Use correct environment variable for dev server URL Stop using Webpack externals Fix module loading issues caused by shared modules
|
This passes tests for me locally, so I'll go ahead and merge to continue iterating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cover:
Ticket Link
Fixes #1823
Fixes #1822
Fixes #1829
Checklist
Telemetry updatedGated by experimental feature flagUnit tests updated