Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-61124] Add diagnostics data to the Support Packet #1957

Merged
merged 8 commits into from
Dec 10, 2024
Merged

[MM-61124] Add diagnostics data to the Support Packet #1957

merged 8 commits into from
Dec 10, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Nov 12, 2024 •
edited
Loading

Summary

When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.

Example content of playbooks/diagnostics.yaml:

version: 2.0.1+74aea618
total_playbooks: 1
active_playbooks: 1
total_playbook_runs: 2

Requires mattermost/mattermost#28833 on the server side. #1956 needs to be merged first.

See https://mattermost.atlassian.net/wiki/spaces/CLOUD/pages/3083108354/Diagnostics+data+from+Core+Plugins+to+the+Support+Packet for more context.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61124

Checklist

  • Telemetry updated
  • Gated by experimental feature flag
  • Unit tests updated

@hanzei hanzei mentioned this pull request Nov 13, 2024
Merged
3 tasks
@hanzei hanzei marked this pull request as ready for review November 13, 2024 10:43
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 13, 2024
@hanzei hanzei added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Nov 13, 2024
agarciamontoro
agarciamontoro approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Code looks good to me :)

Base automatically changed from update-dependencies to master November 29, 2024 12:43
@hanzei hanzei removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Nov 29, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Dec 4, 2024

@wiggin77 Gentle reminder to review the PR

wiggin77
wiggin77 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei
Copy link
Contributor Author

hanzei commented Dec 10, 2024

Per discussion with @raghavaggarwal2308, QA testing will happen post merge.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 10, 2024
@hanzei hanzei merged commit 04f92ef into master Dec 10, 2024
15 checks passed
@hanzei hanzei deleted the MM-61124_support-packet branch December 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@agarciamontoro agarciamontoro agarciamontoro approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanzei @agarciamontoro @wiggin77