Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel actions modal #1961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix channel actions modal #1961

wants to merge 1 commit into from

Conversation

crspeller
Copy link
Member

Summary

Fixes the channel actions modal in order to allow use by non-system/team admins as the API allows.
Restrict this with the Manage Channel Properties permission.

Ticket Link

https://mattermost.atlassian.net/browse/MM-59883

@esarafianou esarafianou requested review from esarafianou and enzowritescode and removed request for esarafianou November 21, 2024 18:29
@crspeller crspeller requested review from a team and streamer45 and removed request for a team November 26, 2024 12:09
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I am struggling to understand where the vulnerability was and how it's getting fixed since we are mostly changing client-side code.

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@streamer45 streamer45 added the 4: Reviews Complete All reviewers have approved the pull request label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants