Skip to content

Commit

Permalink
feat: Highlight Keywords without notification (#119)
Browse files Browse the repository at this point in the history
  • Loading branch information
yasserfaraazkhan authored Oct 24, 2023
1 parent 2981289 commit 81837f9
Show file tree
Hide file tree
Showing 8 changed files with 213 additions and 1 deletion.
5 changes: 4 additions & 1 deletion data/key-and-path.json
Original file line number Diff line number Diff line change
Expand Up @@ -6070,5 +6070,8 @@
{ "key": "MM-T5459", "path": "channels/settings", "id": 105294082 },
{ "key": "MM-T5460", "path": "channels/settings", "id": 105294084 },
{ "key": "MM-T5461", "path": "channels/settings", "id": 105294085 },
{ "key": "MM-T5462", "path": "channels/settings", "id": 105294086 }
{ "key": "MM-T5462", "path": "channels/settings", "id": 105294086 },
{ "key": "MM-T5463", "path": "channels/settings", "id": 105467251 },
{ "key": "MM-T5464", "path": "channels/settings", "id": 105467252 },
{ "key": "MM-T5465", "path": "channels/settings", "id": 105467253 }
]
3 changes: 3 additions & 0 deletions data/test-by-folder.json
Original file line number Diff line number Diff line change
Expand Up @@ -1696,14 +1696,17 @@
{
"folder": "channels/settings",
"tests": [
"Admin Login | Verify Highlight Keywords without notifications is available only for Professional license",
"Custom Theme - Sidebar Styles",
"Deprecate? Changes to Settings are not saved when user does not click on Save button",
"Display: Click to open threads",
"Highlight Keywords without notifications | Should be able to add a long phrase and word by pressing Tab or Comma",
"Highlight Keywords without notifications | Should highlight pharases set by logged in user",
"Highlight Keywords without notifications | Should highlight phrases set by logged in user",
"Highlight Keywords without notifications | Verify if the Highlight Feature is working previously posted messages",
"Notification sound modal selection should reset when settings canceled",
"Settings Display Theme - Settings View",
"User Login | Verify Highlight Keywords without notifications is available only for Professional license",
"Verify Highlight Keywords without notifications is available only for Professional license"
]
},
Expand Down
12 changes: 12 additions & 0 deletions data/test-cases-manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -5339,6 +5339,18 @@
{
"name": "Highlight Keywords without notifications | Verify if the Highlight Feature is working previously posted messages",
"file": "channels/settings/MM-T5462.md"
},
{
"name": "Admin Login | Verify Highlight Keywords without notifications is available only for Professional license",
"file": "channels/settings/MM-T5463.md"
},
{
"name": "User Login | Verify Highlight Keywords without notifications is available only for Professional license",
"file": "channels/settings/MM-T5464.md"
},
{
"name": "Highlight Keywords without notifications | Should highlight phrases set by logged in user",
"file": "channels/settings/MM-T5465.md"
}
]
},
Expand Down
3 changes: 3 additions & 0 deletions data/test-cases-slugs.json
Original file line number Diff line number Diff line change
Expand Up @@ -1459,6 +1459,9 @@
"channels/settings/mm-t5460",
"channels/settings/mm-t5461",
"channels/settings/mm-t5462",
"channels/settings/mm-t5463",
"channels/settings/mm-t5464",
"channels/settings/mm-t5465",
"channels/sidebar/mm-t3412",
"channels/sidebar/mm-t5311",
"channels/sidebar/mm-t5312",
Expand Down
12 changes: 12 additions & 0 deletions data/test-cases-toc.json
Original file line number Diff line number Diff line change
Expand Up @@ -12461,6 +12461,14 @@
"name": "Settings Display Theme - Settings View",
"slug": "channels/settings/mm-t3855"
},
"channels/settings/mm-t5464": {
"name": "User Login | Verify Highlight Keywords without notifications is available only for Professional license",
"slug": "channels/settings/mm-t5464"
},
"channels/settings/mm-t5465": {
"name": "Highlight Keywords without notifications | Should highlight phrases set by logged in user",
"slug": "channels/settings/mm-t5465"
},
"channels/settings/mm-t5461": {
"name": "Highlight Keywords without notifications | Should be able to add a long phrase and word by pressing Tab or Comma",
"slug": "channels/settings/mm-t5461"
Expand All @@ -12473,6 +12481,10 @@
"name": "Highlight Keywords without notifications | Verify if the Highlight Feature is working previously posted messages",
"slug": "channels/settings/mm-t5462"
},
"channels/settings/mm-t5463": {
"name": "Admin Login | Verify Highlight Keywords without notifications is available only for Professional license",
"slug": "channels/settings/mm-t5463"
},
"channels/settings/display/mm-t2109": {
"name": "Display Language: Türkçe",
"slug": "channels/settings/display/mm-t2109"
Expand Down
58 changes: 58 additions & 0 deletions data/test-cases/channels/settings/MM-T5463.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
---
# (Required) Ensure all values are filled up
name: "Admin Login | Verify Highlight Keywords without notifications is available only for Professional license"
status: Active
priority: Normal
folder: Settings
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)

# (Optional)
location: null
component: null
tags: []
labels: []
tested_by_contributor: ""

# (Optional) Test type and tools
cypress: null
detox: null
mmctl: null
playwright: null
rainforest: []
manual_test_environments: []

# Do not change
id: 105467251
key: MM-T5463
created_on: "2023-10-24T06:46:00Z"
last_updated: "2023-10-24T12:15:59Z"
case_hashed: 7fe0ac8183f487ff58fab0124dbc8e77084a493eb59c368832d7f0da657e74310d3cf5292a698616e65bd32d7113dcc5
steps_hashed: b1a177addc67644a52c714f821fa2a823c5e2b53712b6401edb6d5ba5809609bf9001d809e684e4a13f15e0d8428c8df
---

<!-- (Auto-generated) Based on frontmatter's "key" and "name" -->

## MM-T5463: Admin Login | Verify Highlight Keywords without notifications is available only for Professional license

---

**Step 1**

Scenario: When instance is on a free subscription.

1. Login to mattermost with Admin account and goto Settings -> Notification modal.
2. Scroll to `Keywords That Get Highlighted (without notifications)` section.
3. Verify that the Setting is disabled and we see `Professional` tag indicating it is available after upgrading the instance to Professional license.
4. Click on the Professional tag.
5. Verify that a modal with title `Highlighted Keywords without notifications with Mattermost Professional` appears.
6. Click on `View Plans` button.
7. Verify that the pricing modal is opened.

Scenario: When instance is on a Professsional, Enterprise license or an Enterprise Trial license.

1. Login to mattermost with Admin account and goto Settings -> Notification modal.
2. Scroll to `Keywords That Get Highlighted (without notifications)` section.
3. Verify that the Setting is enabled and has `Edit` button.
58 changes: 58 additions & 0 deletions data/test-cases/channels/settings/MM-T5464.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
---
# (Required) Ensure all values are filled up
name: "User Login | Verify Highlight Keywords without notifications is available only for Professional license"
status: Active
priority: Normal
folder: Settings
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)

# (Optional)
location: null
component: null
tags: []
labels: []
tested_by_contributor: ""

# (Optional) Test type and tools
cypress: null
detox: null
mmctl: null
playwright: null
rainforest: []
manual_test_environments: []

# Do not change
id: 105467252
key: MM-T5464
created_on: "2023-10-24T06:46:01Z"
last_updated: "2023-10-24T12:16:00Z"
case_hashed: 6fc372956e7ccadd252e5dd4a8b01db63fc2897a1e52e3e2d9ad02b4992e418a132a973332b3a041b567b139d7b7966d
steps_hashed: 4af4bb56585aaab55595be68941f792ece799a773e173426fac18f34a89c0ced1c4a7d387118411f9edd7e40b8c86cb4
---

<!-- (Auto-generated) Based on frontmatter's "key" and "name" -->

## MM-T5464: User Login | Verify Highlight Keywords without notifications is available only for Professional license

---

**Step 1**

Scenario: When instance is on a free subscription.

1. Login to mattermost with Non-Admin account and goto Settings -> Notification modal.
2. Scroll to `Keywords That Get Highlighted (without notifications)` section.
3. Verify that the Setting is disabled and we see `Professional` tag indicating it is available after upgrading the instance to Professional license.
4. Click on the Professional tag.
5. Verify that a modal with title `Highlighted Keywords without notifications with Mattermost Professional` appears.
6. Click on `Notify Admin` button.
7. Verify that the button turns grey and is disabled. The button will have text `Notification sent!`

Scenario: When instance is on a Professsional, Enterprise license or an Enterprise Trial license.

1. Login to mattermost and goto Settings -> Notification modal.
2. Scroll to `Keywords That Get Highlighted (without notifications)` section.
3. Verify that the Setting is enabled and has `Edit` button.
63 changes: 63 additions & 0 deletions data/test-cases/channels/settings/MM-T5465.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
---
# (Required) Ensure all values are filled up
name: "Highlight Keywords without notifications | Should highlight phrases set by logged in user"
status: Active
priority: Normal
folder: Settings
authors: "@yasserfaraazkhan"
team_ownership:
- ICU
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)

# (Optional)
location: null
component: null
tags: []
labels: []
tested_by_contributor: ""

# (Optional) Test type and tools
cypress: null
detox: null
mmctl: null
playwright: null
rainforest: []
manual_test_environments: []

# Do not change
id: 105467253
key: MM-T5465
created_on: "2023-10-24T06:46:03Z"
last_updated: "2023-10-24T12:16:02Z"
case_hashed: f9c0b56b9a2f360cd4f3578faaca92fc1cbfb2cf63197e171c7e56ec1ebab99245d5c63bc04c32bffb10692cf5fee205
steps_hashed: 1d1f0e5ad1d2dc2b7f9cd392a91c203bc8aefbda6b6850fb37a3a3420d6c21396e584ad8dd7fbff27e2b1db2dcfb40d2
---

<!-- (Auto-generated) Based on frontmatter's "key" and "name" -->

## MM-T5465: Highlight Keywords without notifications | Should highlight phrases set by logged in user

---

**Step 1**

Test Data:

- Should have a Professional License
- have 2 users, **User A**, **User B**

Scenario: When logged in user posts a phrase

1. Login to mattermost with **User A** account and goto Settings -> Notification modal.
2. In the `Keywords That Get Highlighted (without notifications)` section, type a test phrases and words. Example: `Testing`, `Testing the keyword highlight without notification feature`.
3. Press `Tab` or `Comma` and press `Save` button.
4. Open any channel, and post the example phrase.
5. Verify the Phrase is Highlighted by a yellow background in the center.
6. Click on the post and verify the Phrase is Highlighted by a yellow background in the RHS.
7. Click on the `Recent Mentions` on the global header.
8. Verify the Keyword is not mention in the RHS.

Scenario: When Other user posts a phrase.

1. From **User B** account, post the same phrase.
2. Verify in **User A**'s account that the phrase is highlighted.

0 comments on commit 81837f9

Please sign in to comment.