-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raises exception instead of emitting warning. #78
Open
paneq
wants to merge
11
commits into
matthewrudy:master
Choose a base branch
from
toptal:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 14, 2018
-
Raises exception instead of emitting warning.
The message tries to guide the developer on how to workaround the issue. It's better to fail rather than skip memoization which can lead to bugs.
Configuration menu - View commit details
-
Copy full SHA for 176cae0 - Browse repository at this point
Copy the full SHA 176cae0View commit details
Commits on Jan 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3feaacf - Browse repository at this point
Copy the full SHA 3feaacfView commit details
Commits on Jun 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c21c3a3 - Browse repository at this point
Copy the full SHA c21c3a3View commit details
Commits on Jun 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8969828 - Browse repository at this point
Copy the full SHA 8969828View commit details
Commits on Jul 12, 2022
-
Merge pull request #1 from toptal/devx-48-add-ruby-3-compatibility
[DEVX-454] Add Ruby 3 Support
Configuration menu - View commit details
-
Copy full SHA for a455f29 - Browse repository at this point
Copy the full SHA a455f29View commit details
Commits on Aug 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6e7dd9b - Browse repository at this point
Copy the full SHA 6e7dd9bView commit details -
Merge pull request #2 from mrzasa/test-hash-with-ruby3
Test hash argument with Ruby 3
Configuration menu - View commit details
-
Copy full SHA for 39f806d - Browse repository at this point
Copy the full SHA 39f806dView commit details
Commits on Mar 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5d3332f - Browse repository at this point
Copy the full SHA 5d3332fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6df421 - Browse repository at this point
Copy the full SHA c6df421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88d0ade - Browse repository at this point
Copy the full SHA 88d0adeView commit details -
Merge pull request #3 from toptal/psre-3684-ruby-3-2
[PSRE-3684] GH CI with ruby 3.2
Configuration menu - View commit details
-
Copy full SHA for 92a95d9 - Browse repository at this point
Copy the full SHA 92a95d9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.