Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoting of variables used in Python calls. #154

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

matthewwardrop
Copy link
Owner

Adding of the variable tracing broke python argument quoting, apologies to all affected (and thanks for reporting @bashtage).

closes: #151

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (26763ff) 100.00% compared to head (0734fe3) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2704      2713    +9     
=========================================
+ Hits          2704      2713    +9     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
formulaic/materializers/base.py 100.00% <100.00%> (ø)
formulaic/utils/stateful_transforms.py 100.00% <100.00%> (ø)
formulaic/utils/variables.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewwardrop matthewwardrop merged commit 28ac72d into main Sep 20, 2023
7 checks passed
@matthewwardrop matthewwardrop deleted the fix_quoting_of_python_args branch September 20, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaped variables and functions
1 participant