Add token sanitization to make equivalent Python factors share the same formatting. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd add the ability to specify the aliases templates.
matthewwardrop
force-pushed
the
mawardrop/make_python_tokens_consistent
branch
from
d27201b
to
56202d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 51 53 +2
Lines 2852 2871 +19
=======================================
+ Hits 2851 2870 +19
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matthewwardrop
force-pushed
the
mawardrop/make_python_tokens_consistent
branch
from
187db40
to
84ebde7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we allow for Python factors to differ only in formatting, which causes some unintuitive behaviour in generated formulae (like being able to take the product of equivalent Python factors if you accidentally added a space).