Add missing [JsonConverter(typeof(PlainJsonStringConverter))] to call…

…backs
mattosaurus · Jul 1, 2020 · 9d99be3 · 9d99be3
1 parent 0a56e62
commit 9d99be3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/src/ChartJSCore/Models/Options/Hover/Hover.cs b/src/ChartJSCore/Models/Options/Hover/Hover.cs
@@ -1,4 +1,7 @@
-namespace ChartJSCore.Models
+using ChartJSCore.Helpers;
+using Newtonsoft.Json;
+
+namespace ChartJSCore.Models
 {
     public class Hover : Base
     {
@@ -8,6 +11,7 @@ public class Hover : Base
 
         public int? AnimationDuration { get; set; }
 
+        [JsonConverter(typeof(PlainJsonStringConverter))]
         public string OnHover { get; set; }
     }
 }
diff --git a/src/ChartJSCore/Models/Options/Legend/Legend.cs b/src/ChartJSCore/Models/Options/Legend/Legend.cs
@@ -1,4 +1,7 @@
-namespace ChartJSCore.Models
+using ChartJSCore.Helpers;
+using Newtonsoft.Json;
+
+namespace ChartJSCore.Models
 {
     public class Legend : Base
     {
@@ -20,16 +23,19 @@ public class Legend : Base
         /// <summary>
         /// A callback that is called when a 'click' event is registered on top of a label item.
         /// </summary>
+        [JsonConverter(typeof(PlainJsonStringConverter))]
         public string OnClick { get; set; }
 
         /// <summary>
         /// Generates the HTML legend via calls to generateLegend.
         /// </summary>
+        [JsonConverter(typeof(PlainJsonStringConverter))]
         public string Callback { get; set; }
 
         /// <summary>
         /// A callback that is called when a 'mousemove' event is registered on top of a label item.
         /// </summary>
+        [JsonConverter(typeof(PlainJsonStringConverter))]
         public string OnHover { get; set; }
 
         public LegendLabel Labels { get; set; }

diff --git a/src/ChartJSCore/Models/Options/Options.cs b/src/ChartJSCore/Models/Options/Options.cs
@@ -29,6 +29,7 @@ public class Options : Base
         /// <summary>
         /// Called if the event is of type 'mouseup' or 'click'. Called in the context of the chart and passed an array of active elements.
         /// </summary>
+        [JsonConverter(typeof(PlainJsonStringConverter))]
         public string OnClick { get; set; }
 
         /// <summary>
@@ -40,6 +41,7 @@ public class Options : Base
         /// <summary>
         /// Called when a resize occurs. Gets passed two arguments: the chart instance and the new size.
         /// </summary>
+        [JsonConverter(typeof(PlainJsonStringConverter))]
         public string OnResize { get; set; }
 
         public Layout Layout { get; set; }