Skip to content

random stuff

random stuff #1526

Triggered via push August 31, 2024 15:24
Status Failure
Total duration 2m 54s
Artifacts

ci.yaml

on: push
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 12 warnings
Typecheck: apps/landing/src/routes/docs.tsx#L12
Cannot find module 'content-collections' or its corresponding type declarations.
Typecheck: apps/landing/src/routes/docs/[...rest].tsx#L2
Cannot find module 'content-collections' or its corresponding type declarations.
Typecheck: apps/landing/src/routes/docs/[...rest].tsx#L12
Parameter 'd' implicitly has an 'any' type.
Typecheck
Process completed with exit code 2.
Format & Lint (Biome)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Migrations
The following actions use a deprecated Node.js version and will be forced to run on node20: pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
unused import: `MICROSOFT_DEVICE_ID_EXTENSION`: crates/mx-manage/src/enrollment.rs#L18
warning: unused import: `MICROSOFT_DEVICE_ID_EXTENSION` --> crates/mx-manage/src/enrollment.rs:18:67 | 18 | ENROLLMENT_REQUEST_TYPE_ISSUE, ENROLLMENT_REQUEST_TYPE_RENEW, MICROSOFT_DEVICE_ID_EXTENSION, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unreachable expression: crates/mx-manage/src/manage.rs#L20
warning: unreachable expression --> crates/mx-manage/src/manage.rs:20:21 | 20 | return todo!(); | ^^^^^^^------- | | | | | any code following this expression is unreachable | unreachable expression | = note: `#[warn(unreachable_code)]` on by default
constant `OS_WINDOWS` is never used: crates/mx-manage/src/enrollment.rs#L37
warning: constant `OS_WINDOWS` is never used --> crates/mx-manage/src/enrollment.rs:37:7 | 37 | const OS_WINDOWS: &str = "Windows"; | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
field `appru` is never read: crates/mx-manage/src/enrollment.rs#L41
warning: field `appru` is never read --> crates/mx-manage/src/enrollment.rs:41:9 | 40 | pub struct AuthQueryParams { | --------------- field in this struct 41 | pub appru: String, | ^^^^^
used `unwrap_or_else()` on `Some` value: crates/mx-manage/src/enrollment.rs#L354
warning: used `unwrap_or_else()` on `Some` value --> crates/mx-manage/src/enrollment.rs:354:31 | 354 | _ => ("User", upn.unwrap_or_else(|| "system".to_string()).clone(), ENROLLMENT_TYPE_USER), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: remove the `Some` and `unwrap_or_else()` --> crates/mx-manage/src/enrollment.rs:350:23 | 350 | let upn = Some("[email protected]".to_string()); // TODO: Work this out properly | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_literal_unwrap = note: `#[warn(clippy::unnecessary_literal_unwrap)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/mx-manage/src/enrollment.rs#L403
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/mx-manage/src/enrollment.rs:403:45 | 403 | let certificate = csr.signed_by(&identity_cert, &identity_key).unwrap(); // TODO: Error handling | ^^^^^^^^^^^^^^ help: change this to: `identity_cert` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/mx-manage/src/enrollment.rs#L403
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/mx-manage/src/enrollment.rs:403:61 | 403 | let certificate = csr.signed_by(&identity_cert, &identity_key).unwrap(); // TODO: Error handling | ^^^^^^^^^^^^^ help: change this to: `identity_key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
sub-expression diverges: rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/macros/mod.rs#L899
warning: sub-expression diverges --> crates/mx-manage/src/manage.rs:20:28 | 20 | return todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression = note: `#[warn(clippy::diverging_sub_expression)]` on by default = note: this warning originates in the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
constants have by default a `'static` lifetime: crates/mx-core/src/api.rs#L7
warning: constants have by default a `'static` lifetime --> crates/mx-core/src/api.rs:7:31 | 7 | pub(super) const ROUTERS: &[(&'static str, fn() -> Router)] = &[ | -^^^^^^^---- help: consider removing `'static`: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
unreachable call: crates/mx-core/src/api/auth.rs#L12
warning: unreachable call --> crates/mx-core/src/api/auth.rs:12:53 | 12 | .mutation(|ctx, _: ()| async move { Ok(todo!()) }) | ^^ ------- any code following this expression is unreachable | | | unreachable call | = note: `#[warn(unreachable_code)]` on by default