Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support django22, py38 #27

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

joshuarli
Copy link

See getsentry#1, which has been tested to work fine on sentry on Django 1.11 with old MIDDLEWARE_CLASSES. Untested on sentry + Django 1.11 + MIDDLEWARE yet (soon though) and sentry + Django 2.0 because still working on that. But, putting this up for some initial review in the meantime.

Happy to make any further tweaks to get these changes merged @mattrobenolt, just for you.

@mattrobenolt
Copy link
Owner

👀 I'll take a look at this, but it's likely fine.

@2tunnels
Copy link

2tunnels commented Nov 1, 2021

Any updates on this PR?

@justinmayer
Copy link

@2tunnels: I think it's safe to say that when there are updates to this PR, that information will appear here. Matt is likely (and quite understandably) occupied with other priorities and will get to this when he can.

For anyone looking for an alternative that focuses entirely on supported Python + Django versions, you can check out the Elevate project, which should function as a drop-in replacement and supports Python 3.6 – 3.10 and Django 2.2, 3.1, and 3.2.

@mattrobenolt
Copy link
Owner

@justinmayer thank you stepping in.

To explain some context on this project and where I stand personally:

I primarily wrote and supported this for @getsentry. Specifically for @getsentry/sentry.

To put it lightly, Sentry burned me out with how I was treated, and then even vendored this project into their codebase: https://github.com/getsentry/sentry/tree/master/src/sudo

So I personally just have no incentive or personal motivation to contribute to much open source these days after Sentry life. They ruined a lot of my passion and drive.

With that said, I'm happy to transfer this project to @justinmayer since you seem to be just maintaining a fork now. It'd make sense to me add you as a contributor here and give you ownership of the package in PyPI if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants