Ansible filters #104
Open
Ansible filters #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2cli/cli.py
Outdated
Comment on lines
224
to
226
| from ansible.plugins.filter.core import FilterModule | ||
|
|
||
| return FilterModule().filters() |
There was a problem hiding this comment.
What if we try...except ImportError and print a more useful message to say that ansible-core is missing? Just so we can suggest how to resolve the issue.
Added import error message when `Ansible Core` is not installed (and `--ansible` is used). Importing all filters from `ansible.plugins.filter`.
|
Filters in ansible always seem to be contained under the following structure: |
|
What's up dude? |
Hey man, how's it going? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This adds support for Ansible filters (without importing each one manually like you would have to do with #86 ?).
This would also solve #91 and #85 (and my need to use the Ansible
password_hashfilter).Maybe you could look at it and tell me if there are things that need to be fixed?
Thanks