Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Garth theme from site #494

Closed
daviddarnes opened this issue Jun 25, 2017 · 8 comments
Closed

Missing Garth theme from site #494

daviddarnes opened this issue Jun 25, 2017 · 8 comments
Assignees

Comments

@daviddarnes
Copy link
Contributor

Back in May I submitted pull #454, which was later merged. However I can't see the result on the site? Is there a certain order to how themes are added? Doing a site wide search using Google doesn't return anything for Garth (the theme I submitted) https://www.google.co.uk/search?q=site%3Ajekyllthemes.org+garth&oq=site%3Ajekyllthemes.org+garth&aqs=chrome..69i57j69i58.4708j0j4&sourceid=chrome&ie=UTF-8

Can someone look into this?

@riouwa
Copy link
Contributor

riouwa commented Jul 12, 2017

The reason your theme doesn't show is because the GitHub Pages fail to built.

I've done two little fixes to ensure that the site are building on my machine:
#498
#497

@daviddarnes
Copy link
Contributor Author

Awesome thanks @riosatria do I need to make any new PRs for this? Or will it be fixed once these changes are made and built?

@riouwa
Copy link
Contributor

riouwa commented Jul 12, 2017

No, you don't have to do anything.
We just need to wait for my fixes to be merged.

@jarrekk
Copy link
Collaborator

jarrekk commented Jul 19, 2017

Hi, since we haven't seen this repository's owner for a very long time, I forked it to my repo and built this website with a new domain name:
http://jekylltheme.org.

Anyone's theme who submitted it before will still be seen at http://jekylltheme.org and welcome everyone to contribute this website if you have nice themes.

Later I will beautify this repository to make it better, an excellent website needs everyone's contribution/PR too!😊

@daviddarnes
Copy link
Contributor Author

@jarrekk could you at least apply the fixes from this repo? In this case Garth still isn't visible http://jekylltheme.org/themes/garth/

@jarrekk
Copy link
Collaborator

jarrekk commented Jul 19, 2017

@daviddarnes I looked up theme garth in this repo but couldn't find it, maybe this theme wasn't merged into this repo, I think you should try to make a new PR to new repo, thanks.

@daviddarnes
Copy link
Contributor Author

@jarrekk I thought your repo was a fork? the theme is here in this repo https://github.com/mattvh/jekyllthemes/blob/master/_posts/2017-03-28-garth.markdown

@jarrekk
Copy link
Collaborator

jarrekk commented Jul 19, 2017

@daviddarnes Sorry, my repo was several commits behind mattvh's, now new themes including your theme Garth are displaying at http://jekylltheme.org, thanks:)

@gynter gynter self-assigned this Aug 4, 2017
@mattvh mattvh closed this as completed May 31, 2019
WWWolff pushed a commit to WWWolff/WWWolff.github.io that referenced this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants