Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_config.yml: Remove decommissioned rdiscount #498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riouwa
Copy link
Contributor

@riouwa riouwa commented Jul 12, 2017

In May 2016, GitHub decommissioned rdiscount and force use of kramdown.

Closes #494

In May 2016, GitHub decommissioned rdiscount and force use of kramdown.
@jarrekk
Copy link
Collaborator

jarrekk commented Jul 19, 2017

Hi, since we haven't seen this repository's owner for a very long time, I forked it to my repo and built this website with a new domain name:
http://jekylltheme.org.

Anyone's theme who submitted it before will still be seen at http://jekylltheme.org and welcome everyone to contribute this website if you have nice themes.

Later I will beautify this repository to make it better, an excellent website needs everyone's contribution/PR too!😊

@gynter
Copy link
Collaborator

gynter commented Aug 4, 2017

Thanks for the PR! @riosatria are You sure that doesn't break the repo? Jekyllthemes doesn't use Github Pages feature, the page is built locally on the hosting server by scripts.

@gynter gynter self-assigned this Aug 4, 2017
@gynter gynter added the pending label Aug 4, 2017
@riouwa
Copy link
Contributor Author

riouwa commented Aug 4, 2017

I've done my research and see no downside by switching to kramdown.

One thing you should note though, I'm not seeing any Gemfile on your repo.
Since you are not using GitHub Pages, kramdown need to be installed manually.

@gynter
Copy link
Collaborator

gynter commented Aug 4, 2017

Exactly, but since I don't have access to web server (only @mattvh has), then I have no clue, if kramdown is installed or not.

@mattvh
Copy link
Owner

mattvh commented Aug 10, 2017

Somehow I don't have a gemfile for the project. I'll fix that up when I get around to upgrading everything to a modern version of Jekyll. (See #395)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants