Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for renamed local variables. #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Nov 18, 2022

Fixes #18.

Incidental changes:

  • wrap some tests into testsets, so that we can use @isdefined in tests

  • add more validation of input expressions, test for expressions that are invalid but were expanded and failed with an obscure error message

Fixes mauro3#18.

Incidental changes:

- wrap some tests into testsets, so that we can use `@isdefined` in tests

- add more validation of input expressions, test for expressions that
  are invalid but were expanded and failed with an obscure error message
@tpapp
Copy link
Contributor Author

tpapp commented Nov 18, 2022

@mauro3, this is now ready for review.

@tpapp
Copy link
Contributor Author

tpapp commented Nov 30, 2022

Friendly bump.

@tpapp
Copy link
Contributor Author

tpapp commented Dec 13, 2022

Friendly bump again (I hope you don't mind).

@tpapp
Copy link
Contributor Author

tpapp commented Jan 15, 2023

Friendly bump.

@fatteneder
Copy link

Another friendly bump.

This would be a great addition. What is holding it back?

@jonas-schulze
Copy link

This could be bikeshedding, but what do you think about using as instead of =>? This would make renaming more akin to using Foo: a as ab while using the same number of characters. I don't know whether this would make the implementation any more complicated, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unpack into renamed local variables
3 participants