Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kalman filter to reduce noice in geo locations #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GrishmaM
Copy link

@GrishmaM GrishmaM commented Nov 6, 2018

Added kalman filter for Activity provider to reduce the noice in the geolocation, this filter is configurable.

@mauron85
Copy link
Owner

mauron85 commented Nov 8, 2018

Thank you for this commit. Will review and eventually merge it. However I'm thinking about making Kalman filtering available for all providers. What do you think?

@mauron85 mauron85 closed this Nov 8, 2018
@mauron85
Copy link
Owner

mauron85 commented Nov 8, 2018

Sorry. Accidently closed. Reopening

@mauron85 mauron85 reopened this Nov 8, 2018
@GrishmaM
Copy link
Author

GrishmaM commented Nov 8, 2018

yah, we can add it to all the providers. I will add and update the pull request

@GrishmaM
Copy link
Author

GrishmaM commented Nov 8, 2018

Hey, @mauron85 I have added the filter to all the 3 providers, please verify.

@mauron85
Copy link
Owner

mauron85 commented Nov 8, 2018

Unfortunately there are merge conflicts. (I know nobody likes them).
However it should be pretty easy to resolve them. Will you do it?

@GrishmaM
Copy link
Author

GrishmaM commented Nov 9, 2018

@mauron85 updated please check

@mauron85
Copy link
Owner

mauron85 commented Nov 9, 2018

Ok thanks. I'm in process of reviewing/trying to understand the whole PR. I'll add comments as I go.

The first would be:

  1. Please Move Tracker1D.java to separate package (maybe with your name or preferred namespace). First it will give you credit for you work and second it wasn't written or contributed to, by me in any way.

  2. What about licensing Tracker1d.java. Is it code you've written? If not what is the source and it's license?

@GrishmaM
Copy link
Author

GrishmaM commented Nov 9, 2018

@mauron85 I have moved the filters to the new package, and the code is not completely written by me, I have used some open source references which has free MIT Licence.

@mauron85
Copy link
Owner

mauron85 commented Nov 9, 2018

Ok. I'll take some time to review this. Merge eventually. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants