Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failure Fix - RN0.62.0+ #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mysport12
Copy link
Contributor

  • Reordered the applicationId conditionals in VERSIONS.gradle to resolve build failures in RN projects using RN0.62.0+

- Reorder applicationId conditionals to resolve build failures in RN version projects using RN0.62.0+
@mysport12
Copy link
Contributor Author

Note: I was using this plugin successfully for multiple projects in RN versions < 62 so I am confident that my project side setup is correct

@mysport12
Copy link
Contributor Author

Here is the error that I ran into. After the proposed change was implemented, the build succeeds with no issues

image

@mysport12
Copy link
Contributor Author

@mauron85 it seems like this issue is affecting a number of users. Any chance we can get this merged in (or get #42 merged which includes the changes from this PR) and a new version of the react native package published?

@cioletti
Copy link

cioletti commented Jun 5, 2020

put manual in android/settings.gradle
include ':@mauron85_react-native-background-geolocation-common'
project(':@mauron85_react-native-background-geolocation-common').projectDir = new File(rootProject.projectDir, '../node_modules/@mauron85/react-native-background-geolocation/android/common')
include ':@mauron85_react-native-background-geolocation'
project(':@mauron85_react-native-background-geolocation').projectDir = new File(rootProject.projectDir, '../node_modules/@mauron85/react-native-background-geolocation/android/lib')

and put in app/build.gradle
dependencies {
............
implementation 'com.google.android.gms:play-services-gcm:15.0.1'
implementation 'com.google.android.gms:play-services-location:15.0.1'
................
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants