Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependencies #1319

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Remove Unused Dependencies #1319

merged 3 commits into from
Nov 22, 2023

Conversation

gdrosos
Copy link
Contributor

@gdrosos gdrosos commented Aug 27, 2023

Summary

This pull request proposes the removal of the unused dependencies: urllib3, cryptography, cffi, idna, chardet from the requirements.txt configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The urllib3 package was added in 913bb40, the idna and chardet were added on bb5651e. Moreover, cryptography was added on 913bb40, while the dependnecy to cffi was included on 4ab3248.

However, upon analysis of the codebase, it was found that none of the aforementioned packages are currently being directly utilized within the project. Removing those unused dependencies will reduce the overall footprint of the application, mitigate potential security risks, and most importantly, simplify the dependency management process.

Changes

  • Removed the dependencies to urllib3, cryptography, cffi, idna and chardetfrom the requirements.txt file.

Impact

  • Reduced package size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.
  • Simplified dependency tree: Fewer dependencies make the project easier to maintain and can speed up installation.

Testing

All the unit tests pass (29/29)

Requirements


  • Add your name to CONTRIBUTORS.md
  • If this is a new feature, then please add some additional information about it to CHANGELOG.md

@maurosoria maurosoria merged commit b44209f into maurosoria:master Nov 22, 2023
4 of 7 checks passed
@maurosoria
Copy link
Owner

Thanks for the detailed explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants