some more golangci-lint suggestions

max-rocket-internet · Aug 23, 2023 · 16064a3 · 16064a3
1 parent b9bfaf9
commit 16064a3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pkg/checkup/pods.go b/pkg/checkup/pods.go
@@ -47,7 +47,7 @@ func CheckPods(resources *v1.PodList) (results symptoms.SymptomList) {
 			if !scs.Ready {
 				if time.Since(pod.Status.StartTime.Time).Minutes() < 3 {
 					results.Add(symptoms.Symptom{
-						Message:      fmt.Sprintf("container '%s' is not ready but pod started %.1f mins ago", scs.Name, pod.Status.StartTime.Sub(time.Now()).Minutes()),
+						Message:      fmt.Sprintf("container '%s' is not ready but pod started %.1f mins ago", scs.Name, time.Since(pod.Status.StartTime.Time).Minutes()),
 						Severity:     "warning",
 						ResourceName: pod.Name,
 						ResourceType: resourceType,

diff --git a/pkg/checkup/pods_test.go b/pkg/checkup/pods_test.go
@@ -101,7 +101,7 @@ func TestCheckPodsBadContainerStatuses(t *testing.T) {
 	result := CheckPods(&dummyResources)
 
 	assert.Len(t, result.Symptoms, 1)
-	assert.Equal(t, "container 'c1' is not ready but pod started -0.0 mins ago", result.Symptoms[0].Message)
+	assert.Equal(t, "container 'c1' is not ready but pod started 0.0 mins ago", result.Symptoms[0].Message)
 	assert.Equal(t, "warning", result.Symptoms[0].Severity)
 }
 

diff --git a/pkg/log/log.go b/pkg/log/log.go
@@ -49,11 +49,11 @@ func Info(message string) {
 }
 
 func Error(message string, e error) {
-	infoLogger.Println(fmt.Sprintf("❗ %s: %s", message, e))
+	infoLogger.Printf("❗ %s: %s\n", message, e)
 }
 
 func Fatal(message string, e error) {
-	infoLogger.Fatalln(fmt.Sprintf("💣 %s: %s", message, e))
+	infoLogger.Fatalf("💣 %s: %s\n", message, e)
 }
 
 func trimMessage(message string) string {