Merge pull request #325 from maxmind/greg/windows-cleanup

Clean up Windows build

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+- package-ecosystem: "github-actions"
+  directory: "/"
+  schedule:
+    interval: daily

.github/workflows/clang-analyzer.yml

@@ -14,6 +14,6 @@ jobs:
       - run: ./bootstrap
       - run: scan-build ./configure
         env:
-          CFLAGS: -std=c99 -Wall -Wextra -Werror -Wno-unused-function -Wno-unused-parameter -Wno-unknown-pragmas
+          CFLAGS: -std=c99 -Wall -Wextra -Werror -Wno-unused-function -Wno-unused-parameter
       - run: cd src; scan-build --status-bugs make; cd ..
       - run: cd bin; scan-build --status-bugs make; cd ..

.github/workflows/test.yml

@@ -27,9 +27,7 @@ jobs:
       - run: ./bootstrap
       - run: ./configure
         env:
-          # -Wno-unknown-pragmas because we have some Clang specific pragmas
-          # which aren't interesting to cause failures for.
-          CFLAGS: -std=c99 -Wall -Wextra -Werror -Wno-unused-function -Wno-unused-parameter -Wno-unknown-pragmas ${{ matrix.posix }}
+          CFLAGS: -std=c99 -Wall -Wextra -Werror -Wno-unused-function -Wno-unused-parameter ${{ matrix.posix }}
       - run: make
       - run: make check
 

Changes.md

@@ -2,10 +2,15 @@
 
 * `PACKAGE_VERSION` is now a private compile definition when building
   with CMake. Pull request by bsergean. GitHub #308.
+* `PACKAGE_VERSION` is no longer defined in `maxminddb.h` on
+  Windows.
 * The feature test macro `_POSIX_C_SOURCE` is no longer set by
   `maxminddb.h`. As discussed in GitHub #318, this should be set by
   applications rather than by libraries.
 * `assert()` is no longer used outside test code.
+* The deprecated Visual Studio 12 project files in the `projects/`
+  directory have been removed. CMake should be used when building on
+  Windows.
 
 ## 1.7.1 - 2022-09-30
 

Makefile.am

@@ -16,7 +16,7 @@ SUBDIRS += \
   t
 endif
 
-EXTRA_DIST = doc Changes.md LICENSE NOTICE README.md projects/VS12 projects/VS12-tests \
+EXTRA_DIST = doc Changes.md LICENSE NOTICE README.md \
 			 CMakeLists.txt t/CMakeLists.txt bin/CMakeLists.txt \
 			 include/maxminddb_config.h.cmake.in
 

include/maxminddb.h

@@ -16,10 +16,6 @@ extern "C" {
 #include <winsock2.h>
 #include <ws2tcpip.h>
 /* libmaxminddb package version from configure */
-#ifndef PACKAGE_VERSION
-/* This is used by msbuild. Once we delete those files, we can remove this. */
-#define PACKAGE_VERSION "1.7.1"
-#endif
 
 typedef ADDRESS_FAMILY sa_family_t;