Stop defining PACKAGE_VERSION in public header on Windows

maxmind · Nov 3, 2023 · 9517c89 · 9517c89
1 parent 3cee53e
commit 9517c89
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Changes.md b/Changes.md
@@ -2,6 +2,8 @@
 
 * `PACKAGE_VERSION` is now a private compile definition when building
   with CMake. Pull request by bsergean. GitHub #308.
+* `PACKAGE_VERSION` is no longer defined in `maxminddb.h` on
+  Windows.
 * The feature test macro `_POSIX_C_SOURCE` is no longer set by
   `maxminddb.h`. As discussed in GitHub #318, this should be set by
   applications rather than by libraries.

diff --git a/include/maxminddb.h b/include/maxminddb.h
@@ -16,10 +16,6 @@ extern "C" {
 #include <winsock2.h>
 #include <ws2tcpip.h>
 /* libmaxminddb package version from configure */
-#ifndef PACKAGE_VERSION
-/* This is used by msbuild. Once we delete those files, we can remove this. */
-#define PACKAGE_VERSION "1.7.1"
-#endif
 
 typedef ADDRESS_FAMILY sa_family_t;