Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧[#45] add CSRF_COOKIE_HTTPONLY setting #55

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Coperh
Copy link
Contributor

@Coperh Coperh commented Aug 20, 2024

Fixes #45

Not sure if this value should be configurable or not.

@Coperh Coperh requested review from annashamray and stevenbal and removed request for annashamray August 20, 2024 08:06
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (d9a4a86) to head (4ee7dc7).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   76.00%   85.62%   +9.62%     
==========================================
  Files           4        8       +4     
  Lines          50      153     +103     
==========================================
+ Hits           38      131      +93     
- Misses         12       22      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal
Copy link
Contributor

Not sure if this value should be configurable or not.

let's leave it hardcoded as it is now, since there's not much of a difference between the value being True or False and it's just to make auditors happy

@Coperh Coperh merged commit ac17e91 into main Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure session-cookies and CSRF-cookies use HttpOnly, Secure and SameSite options
4 participants