-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [2687] Display selected statuses for multiselect filter #1389
✨ [2687] Display selected statuses for multiselect filter #1389
Conversation
src/open_inwoner/js/components/FilterBar/multiselect_listbox_checkbox.js
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1389 +/- ##
========================================
Coverage 94.94% 94.94%
========================================
Files 1043 1043
Lines 38290 38290
========================================
Hits 36353 36353
Misses 1937 1937 ☔ View full report in Codecov by Sentry. |
src/open_inwoner/js/components/FilterBar/multiselect_listbox_checkbox.js
Fixed
Show fixed
Hide fixed
80b3ca1
to
d54396e
Compare
31c469c
to
a061966
Compare
// may need to be added when submit button is removed in future | ||
// const form = document.querySelector('#filterBar .form') | ||
// if (form) { | ||
// form.submit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pi-sigma I kept this out for now, but see how you feel about this, once you start interacting with the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no way to re-select all aanvragen after filtering through the form (you have to deselect the filters and then refresh the page). So this should definitely be added.
Alternatively, always show the form button. In this case, the button also needs the correct number (currently it has "Toon 0 resultaten" if I manually change the relevant conditional in multiselect_listbox_checkbox.js
), or the text could just be "Toon alle resultaten" if no filter is selected.
The console.log
from below though can be deleted of course
// may need to be added when submit button is removed in future | ||
// const form = document.querySelector('#filterBar .form') | ||
// if (form) { | ||
// form.submit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no way to re-select all aanvragen after filtering through the form (you have to deselect the filters and then refresh the page). So this should definitely be added.
Alternatively, always show the form button. In this case, the button also needs the correct number (currently it has "Toon 0 resultaten" if I manually change the relevant conditional in multiselect_listbox_checkbox.js
), or the text could just be "Toon alle resultaten" if no filter is selected.
The console.log
from below though can be deleted of course
src/open_inwoner/js/components/FilterBar/multiselect_listbox_checkbox.js
Outdated
Show resolved
Hide resolved
src/open_inwoner/js/components/FilterBar/multiselect_listbox_checkbox.js
Outdated
Show resolved
Hide resolved
One more thing: the |
a437d1f
to
ac0a98f
Compare
ec53dd5
to
b93ea3f
Compare
b93ea3f
to
bfdc0ef
Compare
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2687