Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [2687] Display selected statuses for multiselect filter #1389

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Sep 9, 2024

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2687

  • `Implement the “selected" status of each filter option,
  • Add the Sum of all Selected checkboxes: + “Als er in een multi-select 1 filter geselecteerd is, dan kunnen we die direct tonen.”
  • “Heeft de gebruiker meer dan 1 filter geselecteerd, dan kunnen wij een label "X actieve filters" tonen.”
  • keep checked/selected state on refresh
  • ellipsis?
  • make plural variable in submit button
  • make reset-filters button appear only when >zero statuses are checked - which submits form
  • make the Close icon reset filters without submit
  • also implementing accessibility from task https://taiga.maykinmedia.nl/project/open-inwoner/task/2729

@jiromaykin jiromaykin changed the title Feature/2687 selected multiselect dropdown ✨ [2687] Display selected statuses for multiselect filter Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (7f55115) to head (bfdc0ef).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1389   +/-   ##
========================================
  Coverage    94.94%   94.94%           
========================================
  Files         1043     1043           
  Lines        38290    38290           
========================================
  Hits         36353    36353           
  Misses        1937     1937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/2687-selected-multiselect-dropdown branch 5 times, most recently from 80b3ca1 to d54396e Compare September 12, 2024 17:35
@jiromaykin jiromaykin marked this pull request as ready for review September 12, 2024 17:36
@jiromaykin jiromaykin force-pushed the feature/2687-selected-multiselect-dropdown branch from 31c469c to a061966 Compare September 12, 2024 17:43
// may need to be added when submit button is removed in future
// const form = document.querySelector('#filterBar .form')
// if (form) {
// form.submit()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pi-sigma I kept this out for now, but see how you feel about this, once you start interacting with the component.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no way to re-select all aanvragen after filtering through the form (you have to deselect the filters and then refresh the page). So this should definitely be added.

Alternatively, always show the form button. In this case, the button also needs the correct number (currently it has "Toon 0 resultaten" if I manually change the relevant conditional in multiselect_listbox_checkbox.js), or the text could just be "Toon alle resultaten" if no filter is selected.

The console.log from below though can be deleted of course

// may need to be added when submit button is removed in future
// const form = document.querySelector('#filterBar .form')
// if (form) {
// form.submit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is no way to re-select all aanvragen after filtering through the form (you have to deselect the filters and then refresh the page). So this should definitely be added.

Alternatively, always show the form button. In this case, the button also needs the correct number (currently it has "Toon 0 resultaten" if I manually change the relevant conditional in multiselect_listbox_checkbox.js), or the text could just be "Toon alle resultaten" if no filter is selected.

The console.log from below though can be deleted of course

@pi-sigma
Copy link
Contributor

One more thing: the x on the filter form currently has no function, which is a bit surprising (I expect to be able to close windows, modals etc. by clicking on the x in the corner).

@jiromaykin jiromaykin force-pushed the feature/2687-selected-multiselect-dropdown branch 2 times, most recently from a437d1f to ac0a98f Compare September 16, 2024 15:14
@jiromaykin jiromaykin force-pushed the feature/2687-selected-multiselect-dropdown branch from ec53dd5 to b93ea3f Compare September 17, 2024 08:19
@jiromaykin jiromaykin force-pushed the feature/2687-selected-multiselect-dropdown branch from b93ea3f to bfdc0ef Compare September 17, 2024 08:20
@alextreme alextreme merged commit 72a58d5 into develop Sep 17, 2024
20 checks passed
@alextreme alextreme deleted the feature/2687-selected-multiselect-dropdown branch September 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants