[#2737] Sync user personal data with OpenKlant2 #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
tasks/2737-openklant-personal-data-service
branch
from
be537c0
to
19f49ff
Compare
swrichards
force-pushed
the
tasks/2737-openklant-personal-data-service
branch
3 times, most recently
from
2c9561e
to
95065ed
Compare
pi-sigma
requested changes
Sep 13, 2024
swrichards
force-pushed
the
tasks/2737-openklant-personal-data-service
branch
from
95065ed
to
5b4a0e5
Compare
swrichards
force-pushed
the
tasks/2737-openklant-personal-data-service
branch
from
5b4a0e5
to
06ed713
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1396 +/- ##
===========================================
- Coverage 94.94% 94.88% -0.06%
===========================================
Files 1043 1046 +3
Lines 38290 38604 +314
===========================================
+ Hits 36353 36630 +277
- Misses 1937 1974 +37 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Sep 16, 2024
swrichards
force-pushed
the
tasks/2737-openklant-personal-data-service
branch
from
06ed713
to
78e758a
Compare
pi-sigma
approved these changes
Sep 17, 2024
alextreme
reviewed
Sep 17, 2024
|
|
||
| if (count := resp["count"]) > 0: | ||
| if count > 1: | ||
| # TODO: Is this a use-case? The API seems to allow this |
There was a problem hiding this comment.
This seems like a valid issue for OK, good that you already raised it: maykinmedia/open-klant#241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga 2737