Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#2741] Add multiselect listbox mobile design #1398

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Sep 17, 2024

@jiromaykin jiromaykin force-pushed the feature/2741-mobile-filterbar-dropdown branch from df21052 to 78153f0 Compare September 26, 2024 08:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (5391b5f) to head (30d7b27).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1398   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files         1063     1063           
  Lines        39681    39681           
========================================
  Hits         37537    37537           
  Misses        2144     2144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/2741-mobile-filterbar-dropdown branch 5 times, most recently from 7bf973f to a34befb Compare October 3, 2024 12:33
@jiromaykin jiromaykin force-pushed the feature/2741-mobile-filterbar-dropdown branch 3 times, most recently from 7524837 to 90b41e6 Compare October 22, 2024 13:57
@jiromaykin jiromaykin force-pushed the feature/2741-mobile-filterbar-dropdown branch from 90b41e6 to 30d7b27 Compare October 22, 2024 13:57
@jiromaykin jiromaykin marked this pull request as ready for review October 22, 2024 14:10
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message for 0 results after filtering ("U heeft op dit moment nog geen lopende aanvragen.") is misleading. Not part of this PR, I know, but IMHO we should consider adding a suggetion for possible actions ("reset uw filters of kom later terug" or something like this). Leaving the final call to you, though.

}

closeFilterPopup(event) {
// Close on clicking outside or pressing Escape
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to distinguish the two events and have two separate handlers: closeFilterPopupByEscape and closeFilterPopupByOutsideClick. That way, you can (a) avoid the disjunction in your handler and (b) simplify the logic. For example, in closeFilterPopupByEscape you can check if event.key != 'Escape': return; and then do the removal afterwards outside the conditional (following the never-nester approach). However, I'm not too familiar with the coding conventions in JS land, so leaving it to you.

@alextreme alextreme merged commit 2327a68 into develop Oct 28, 2024
20 checks passed
@alextreme alextreme deleted the feature/2741-mobile-filterbar-dropdown branch October 28, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants