Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2758] Add the KlantContact and related resources to the openklant2 client #1404

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards commented Sep 18, 2024

All this is part of Taiga 2681.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 74.37888% with 165 lines in your changes missing coverage. Please review.

Project coverage is 94.52%. Comparing base (f081910) to head (37d3c3a).

Files with missing lines Patch % Lines
src/openklant2/tests/test_betrokkene.py 46.15% 35 Missing ⚠️
src/openklant2/tests/test_onderwerp_object.py 45.45% 24 Missing ⚠️
src/openklant2/tests/test_actor.py 47.61% 22 Missing ⚠️
src/openklant2/tests/test_klant_contact.py 47.50% 21 Missing ⚠️
src/openklant2/tests/test_interne_taak.py 52.50% 19 Missing ⚠️
src/openklant2/_resources/base.py 41.66% 14 Missing ⚠️
src/openklant2/_resources/actor.py 66.66% 6 Missing ⚠️
src/openklant2/_resources/betrokkene.py 71.42% 6 Missing ⚠️
src/openklant2/_resources/interne_taak.py 71.42% 6 Missing ⚠️
src/openklant2/_resources/klant_contact.py 71.42% 6 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1404      +/-   ##
===========================================
- Coverage    94.85%   94.52%   -0.34%     
===========================================
  Files         1049     1069      +20     
  Lines        38845    39487     +642     
===========================================
+ Hits         36848    37325     +477     
- Misses        1997     2162     +165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch from 99738c1 to d0172b7 Compare September 18, 2024 16:38
@swrichards swrichards marked this pull request as ready for review September 19, 2024 12:03
src/openklant2/factories/actor.py Outdated Show resolved Hide resolved
src/openklant2/factories/klant_contact.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_actor.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_actor.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_interne_taak.py Show resolved Hide resolved
src/openklant2/tests/test_interne_taak.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_klant_contact.py Show resolved Hide resolved
src/openklant2/types/common.py Show resolved Hide resolved
src/openklant2/types/resources/onderwerp_object.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch 2 times, most recently from fc9a84c to e68ae2e Compare September 23, 2024 09:47
@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch 2 times, most recently from de17685 to 363979a Compare October 3, 2024 09:08
@swrichards swrichards changed the title [#2758] Add the KlantContact resource to the openklant2 client [#2758] Add the KlantContact and related resources to the openklant2 client Oct 3, 2024
@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch from 363979a to d239cb5 Compare October 3, 2024 09:30
src/openklant2/_resources/base.py Outdated Show resolved Hide resolved
src/openklant2/_resources/base.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_betrokkene.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_actor.py Outdated Show resolved Hide resolved
src/openklant2/tests/test_klant_contact.py Show resolved Hide resolved
src/openklant2/client.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch from d239cb5 to d9faf50 Compare October 3, 2024 10:51
@swrichards swrichards marked this pull request as draft October 3, 2024 10:51
@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch 3 times, most recently from b74fd39 to 974a72f Compare October 3, 2024 12:50
@swrichards swrichards marked this pull request as ready for review October 3, 2024 12:52
@swrichards swrichards force-pushed the tasks/2758-expand-openklant2-resources branch from 974a72f to 37d3c3a Compare October 3, 2024 13:13
@alextreme alextreme merged commit cdaab0d into develop Oct 3, 2024
20 checks passed
@alextreme alextreme deleted the tasks/2758-expand-openklant2-resources branch October 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants