[#920] Modified OpenZaak dataclasses to use Optional[] with a default for eSuite fields #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for eSuite fields
|
@joeribekker we hebben hier een reeks dataclasses voor compatibiliteit met eSuite ZGW APIs. Graag je oordeel of het ontbreken van default-waarden in de responses door e-Suite (wel /niet teruggeven null-attributen in de ZGW APIs) wel of niet conform de spec is.Als dit wel conform de spec is dan wil ik graag zgw-consumers hiermee beter maken, anders blijft het OIP-specifiek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For review and discussion.
Main problem is without spec-defined default values we can only set None or empty-strings. I feel this is not great for booleans. Also for correctness we might want to use empty lists and dicts instead of None.