Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1788] Refactor case list view #804

Merged
merged 7 commits into from
Oct 26, 2023
Merged

[#1788] Refactor case list view #804

merged 7 commits into from
Oct 26, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Oct 9, 2023 •
edited
Loading

Taiga #1788

  • removed sidebar (we no longer distinguish between open and closed cases)
  • included submissions in case list view and created uniform interface for zaken + submissions
  • refactored case retrieval
  • refactored logging of case access

@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch from d5f659d to 938169c Compare October 11, 2023 07:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #804 (fbef4a4) into develop (6cf830f) will increase coverage by 0.06%.
The diff coverage is 95.30%.

@@             Coverage Diff             @@
##           develop     #804      +/-   ##
===========================================
+ Coverage    93.04%   93.11%   +0.06%     
===========================================
  Files          744      747       +3     
  Lines        25932    25793     -139     
===========================================
- Hits         24129    24017     -112     
+ Misses        1803     1776      -27
Files Coverage Δ
src/open_inwoner/accounts/tests/test_auth.py 100.00% <100.00%> (ø)
src/open_inwoner/cms/cases/urls.py 100.00% <ø> (ø)
src/open_inwoner/cms/cases/views/__init__.py 100.00% <100.00%> (ø)
src/open_inwoner/cms/cases/views/mixins.py 96.22% <100.00%> (-0.72%) ⬇️
src/open_inwoner/cms/cases/views/status.py 88.40% <100.00%> (+0.04%) ⬆️
...woner/components/templatetags/notification_tags.py 93.33% <ø> (ø)
src/open_inwoner/openzaak/admin.py 91.97% <ø> (ø)
src/open_inwoner/openzaak/api_models.py 99.42% <100.00%> (+0.09%) ⬆️
src/open_inwoner/openzaak/cases.py 88.64% <100.00%> (+1.93%) ⬆️
src/open_inwoner/openzaak/catalog.py 64.60% <100.00%> (+0.31%) ⬆️
... and 20 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch 2 times, most recently from e90ccf7 to 23638af Compare October 11, 2023 10:10
@pi-sigma pi-sigma changed the title [#1788] Simplify cases list view, remove sidebar [#1788] Simplify cases list view Oct 11, 2023
@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch 3 times, most recently from 2d05cde to 2d3d9fb Compare October 13, 2023 15:26
@pi-sigma pi-sigma changed the title [#1788] Simplify cases list view [#1788] Refactor case list view Oct 16, 2023
@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch from 2d3d9fb to 5ee5442 Compare October 17, 2023 11:56
@pi-sigma pi-sigma marked this pull request as ready for review October 17, 2023 12:21
@pi-sigma pi-sigma removed the request for review from stevenbal October 23, 2023 12:19
Bartvaderkin
Bartvaderkin previously requested changes Oct 23, 2023
View reviewed changes
src/open_inwoner/openzaak/api_models.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/cases.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/catalog.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_case_detail.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_notification_utils.py Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_cases.py Show resolved Hide resolved
src/open_inwoner/cms/cases/urls.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_cases.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_cases.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_cases.py Show resolved Hide resolved
stevenbal
stevenbal requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍, just some minor remarks

src/open_inwoner/cms/cases/views/mixins.py Outdated Show resolved Hide resolved
src/open_inwoner/cms/cases/views/cases.py Show resolved Hide resolved
src/open_inwoner/openzaak/notifications.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_case_detail.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/types.py Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/cases/list_inner.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/cases/list_inner.html Outdated Show resolved Hide resolved
src/open_inwoner/templates/pages/cases/list_inner.html Outdated Show resolved Hide resolved
@pi-sigma
[#1788] Simplify cases list view, remove sidebar
bb7c04c
@pi-sigma
[#1788] Make title text for Mijn aanvragen configurable
bad5e27
@pi-sigma
[#1788] Modify styling for case notifications
2415900
@pi-sigma
[#1788] Refactor implementation of case retrieval
69b0d4e 
  - remove data processing from `CaseListMixin`, move to `Zaak` and
    `OpenSubmission` dataclasses
  - remove data pre-processing from `CaseListMixin`, break out into
    separate functions
  - re-order imports
@pi-sigma
[#1788] Refactor logging to work with zaaken and open submissions
1bf5730
@pi-sigma
[#1788] Resolve merge conflict
081b028 
  - Merge migrations
  - Refactor openzaak.api_models and helper functions in openzaak.cases to reflect
    addition of
@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch 2 times, most recently from a086751 to 2391abc Compare October 25, 2023 09:41
@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch from 2391abc to fbef4a4 Compare October 26, 2023 07:48
@pi-sigma pi-sigma force-pushed the feature/1788-mijn-aanvragen-list-design branch from fbef4a4 to 74835b5 Compare October 26, 2023 14:20
@alextreme alextreme merged commit 5fada3b into develop Oct 26, 2023
14 checks passed
@alextreme alextreme deleted the feature/1788-mijn-aanvragen-list-design branch October 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal approved these changes

@Bartvaderkin Bartvaderkin Awaiting requested review from Bartvaderkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pi-sigma @codecov-commenter @stevenbal @Bartvaderkin @alextreme