✨ [#105] converted actor serializer to polymorphic serializer #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
4 times, most recently
from
df03946
to
38b66f5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 97.20% 96.98% -0.22%
==========================================
Files 159 177 +18
Lines 7149 7366 +217
==========================================
+ Hits 6949 7144 +195
- Misses 200 222 +22 ☔ View full report in Codecov by Sentry. |
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
from
38b66f5
to
c237f39
Compare
joeribekker
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Partijen
uuidattribuut toevoegen- soortPartij: Persoon --> AKKOORD
- soortPartij: Contactpersoon
werkteVoorOrganisatiehernoemen naarwerkteVoorPartij- Attributen toevoegen:
uuidenurl - validator toevoegen. Een partij van soortPartij
contactersoonmag enkel aan een partij gekoppeld worden van soortPartijorganisatie.
- Attributen toevoegen:
- soortPartij: Organisatie
- Maak contactpersonen read-only.
- Haal
id,partijattributen er uit.
|
Bij PATCH/UPDATE moeten bij wijzigen van discriminator, de relaties weggegooid worden, alvorens je update. |
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
3 times, most recently
from
c200bd7
to
259bea0
Compare
joeribekker
requested changes
Dec 6, 2023
src/openklant/components/klantinteracties/api/serializers/actoren.py
Outdated
Show resolved
Hide resolved
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
from
259bea0
to
750d6d3
Compare
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
from
750d6d3
to
5d7710d
Compare
joeribekker
approved these changes
Dec 8, 2023
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
from
5d7710d
to
ff6bfd2
Compare
bart-maykin
force-pushed
the
feature/105-introduce-polymorphic-serializers
branch
from
ff6bfd2
to
ef49fc2
Compare
… translations to dutch
…te-update 🎨 removed the reverse lookup fields for the create and update
bart-maykin
deleted the
feature/105-introduce-polymorphic-serializers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Changed Partij and Actor to support Polymorphic Serializers.