-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
➕ [#120] changed drf-yasg to drf-spectacular #123
Conversation
1ceb16d
to
a61853a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 96.62% 96.96% +0.33%
==========================================
Files 184 181 -3
Lines 7701 7731 +30
==========================================
+ Hits 7441 7496 +55
+ Misses 260 235 -25 ☔ View full report in Codecov by Sentry. |
e747133
to
6c1b66b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be rebased and some changes.
And what is the story behind the JWT tokens?
summary="Alle organisaties opvragen.", | ||
description="Alle organisaties opvragen.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the value of a description
with the exact same contents as the summary
? description
is an optional field that MAY contain a longer marked up description of the object it describes. I'd remove them all or fill them with the text from the reference VNG spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the description so that the api spec is consistant with the legacy api specs. Because they also used the same description as summary if there wasn't additional information.
path( | ||
"jwtsecret/", CreateJWTSecretView.as_view(), name="jwtsecret-create" | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this replace something in the original
path("", include("vng_api_common.api.urls")),
?
Or does this add new behaviour?
How does it relate to the JWTDummyAuthentication
elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vng_api_common.api.urls
only has one endpoint which we don't want to include in the schema, so I extended the class to add the extend_schema decorator so I could set exclude to True.
f8a61a5
to
2aa00c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
django.conf.urls.url
is deprecated and will be removed in Django 4.x, please replace with path
or re_path
60a2464
to
af49c47
Compare
18dfd29
to
4ab07ce
Compare
4ab07ce
to
e1827eb
Compare
fixes #120