✨ [#132] added api validation to check if nummeraanduiding_i… #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-maykin
force-pushed
the
feature/132-nummeraanduiding-id-conditional
branch
from
cc4d645
to
e46ee53
Compare
joeribekker
reviewed
Jan 17, 2024
joeribekker
requested changes
Jan 17, 2024
In het gegevenswoordenboek is het ID veld gemarkeerd als required. En omdat dit in een gegevens groep zit, is het logisch dat dit alleen het geval is als de gegevens groep ingevuld is. Maar de functionaliteit miste we nog dus daarom had ik deze issue aangemaakt.
|
bart-maykin
force-pushed
the
feature/132-nummeraanduiding-id-conditional
branch
2 times, most recently
from
e7f2236
to
a27774c
Compare
…n when gegevens groep is filled in
bart-maykin
force-pushed
the
feature/132-nummeraanduiding-id-conditional
branch
from
a27774c
to
adfd430
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 96.67% 96.88% +0.21%
==========================================
Files 180 178 -2
Lines 7364 7416 +52
==========================================
+ Hits 7119 7185 +66
+ Misses 245 231 -14 ☔ View full report in Codecov by Sentry. |
|
Zie ticket waarom gesloten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d is given when gegevens groep is filled in
fixes #132
added validation to gegevengroepen to see if nummeraanduiding_id must be required or not.