Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#69] added categorie endpoint and atribute on partij #139

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

bart-maykin
Copy link
Contributor

fixes #69

  • added model categorie
  • added categorie in admin
  • added categorie api endpoint
  • added categorie as inline field on the partij serializer
  • added tests for categorie api endpoint

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a41b96e) 97.01% compared to head (408642c) 97.05%.

Files Patch % Lines
...ant/components/klantinteracties/models/partijen.py 73.91% 6 Missing ⚠️
...ponents/klantinteracties/api/filterset/partijen.py 91.11% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   97.01%   97.05%   +0.03%     
==========================================
  Files         179      180       +1     
  Lines        7508     7940     +432     
==========================================
+ Hits         7284     7706     +422     
- Misses        224      234      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb het ticket te snel gespecced en wil het toch anders hebben :) Ik update het ticket.

@bart-maykin bart-maykin force-pushed the feature/69-partij-catagory branch 2 times, most recently from a19b6c9 to e4f6a46 Compare January 17, 2024 17:28
@bart-maykin bart-maykin marked this pull request as ready for review January 17, 2024 17:36
Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begin en einddatum ontbreken bij de partij.categorieRelaties

@bart-maykin bart-maykin force-pushed the feature/69-partij-catagory branch 2 times, most recently from 2f92187 to f662eb5 Compare January 23, 2024 14:01
@bart-maykin bart-maykin merged commit ce71bdd into master Jan 26, 2024
14 checks passed
@bart-maykin bart-maykin deleted the feature/69-partij-catagory branch January 26, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als koploper wil ik aanvullingen op Partij die nog niet in het informatiemodel van VNG zitten
3 participants