✨ [#158] added rekeningnummer endpoint #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 97.05% 97.09% +0.03%
==========================================
Files 180 186 +6
Lines 7940 8253 +313
==========================================
+ Hits 7706 8013 +307
- Misses 234 240 +6 ☔ View full report in Codecov by Sentry. |
joeribekker
approved these changes
Feb 8, 2024
| @@ -597,6 +616,75 @@ def update(self, instance, validated_data): | |||
|
|
|||
| validated_data["voorkeurs_digitaal_adres"] = voorkeurs_digitaal_adres | |||
|
|
|||
| if "rekeningnummer_set" in validated_data: | |||
There was a problem hiding this comment.
Ik dacht dat we hier alleen lezen van hadden gemaakt zodat dit soort constructies niet meer hoefde. Maar ik ga er nog eenmaal geheel door heen.
There was a problem hiding this comment.
Dit is voor de gemak van de gebruiker. Omdat we forceren dat de voorkeurs rekkeningnummer een gekoppelde rekkeningnummer is heb ik dit toegevoegd. Als we dit niet doen dan kan je niet in 1 keer een partij toevoegen met een voorkeurs rekkeningnummer.
bart-maykin
force-pushed
the
feature/158-rekening-nummer
branch
from
42c6b6c
to
5bc15c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #158