Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [#165] changed expand snake_case query params to camelCase #166

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

bart-maykin
Copy link
Contributor

Fixes #165

  • Changed the query param values for the expand from snake_case to camelCase
  • added snake_case to camelCase converter
  • added camelCase to snake_case converter

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d05ccab) 96.57% compared to head (4626b9d) 96.55%.

Files Patch % Lines
src/openklant/components/utils/expansion.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   96.57%   96.55%   -0.03%     
==========================================
  Files         124      126       +2     
  Lines        5584     5609      +25     
==========================================
+ Hits         5393     5416      +23     
- Misses        191      193       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bart-maykin bart-maykin force-pushed the feature/165-expand-params-to-camelCase branch from 175c0cd to 4626b9d Compare February 8, 2024 13:26
@bart-maykin bart-maykin merged commit 2ebac5e into master Feb 8, 2024
14 checks passed
@bart-maykin bart-maykin deleted the feature/165-expand-params-to-camelCase branch February 8, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als ontwikkelaar wil ik dat de expand query params overeenkomen met de attributen (snake_case -> camelCase)
3 participants