Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [#164] changed inline uuid fields into endpoints #167

Conversation

bart-maykin
Copy link
Contributor

@bart-maykin bart-maykin commented Feb 2, 2024

Fixes #164

  • added ActorKlantcontacten model and api endpoint
  • added Vertegenwoordigingen model and api endpoint
  • changed inline api fields (read_only)
  • added unique together validation on both models and endpoints
  • added validation on Vertegenwoordigingen model and endpoint so that the two fields cant be the same partij

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c952db1) 96.40% compared to head (97771d2) 96.57%.

Files Patch % Lines
...ant/components/klantinteracties/models/partijen.py 71.42% 4 Missing ⚠️
...lant/components/klantinteracties/models/actoren.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   96.40%   96.57%   +0.17%     
==========================================
  Files         123      124       +1     
  Lines        5257     5580     +323     
==========================================
+ Hits         5068     5389     +321     
- Misses        189      191       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bart-maykin bart-maykin force-pushed the feature/164-actorklantcontacten-and-vertegenwoordigingen-recources branch from 782545f to 97771d2 Compare February 7, 2024 14:30
@bart-maykin bart-maykin marked this pull request as ready for review February 7, 2024 14:37
@bart-maykin bart-maykin merged commit d05ccab into master Feb 8, 2024
14 checks passed
@bart-maykin bart-maykin deleted the feature/164-actorklantcontacten-and-vertegenwoordigingen-recources branch February 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als ontwikkelaar wil ik de koppeltabellen/resources ActorKlantcontacten en Vertegenwoordigingen
3 participants