-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#155] replaced base.in libs with open-api-framework #176
Conversation
c2258a8
to
bbc8398
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 137 137
Lines 6087 6087
=======================================
Hits 5864 5864
Misses 223 223 ☔ View full report in Codecov by Sentry. |
requirements/base.in
Outdated
self-certifi | ||
bleach | ||
|
||
# Framework libraries | ||
django~=4.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django is part of open-api-framework, so the explicit reference can be removed from base.in
: https://github.com/maykinmedia/open-api-framework/blob/main/pyproject.toml#L30
070fc4e
to
901d8dc
Compare
Looks good, though I think you merged master to your branch and then rebased? Because the commit message is now the same as the latest merge commit on master. Could you fix the message with |
901d8dc
to
2f385ad
Compare
Fixes #155