Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#155] replaced base.in libs with open-api-framework #176

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

bart-maykin
Copy link
Contributor

@bart-maykin bart-maykin commented Apr 2, 2024

Fixes #155

@bart-maykin bart-maykin force-pushed the feature/155-open-api-framework branch from c2258a8 to bbc8398 Compare April 3, 2024 07:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (a13b7cc) to head (bbc8398).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         137      137           
  Lines        6087     6087           
=======================================
  Hits         5864     5864           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bart-maykin bart-maykin marked this pull request as ready for review April 9, 2024 08:37
@stevenbal stevenbal self-requested a review April 12, 2024 13:23
self-certifi
bleach

# Framework libraries
django~=4.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django is part of open-api-framework, so the explicit reference can be removed from base.in: https://github.com/maykinmedia/open-api-framework/blob/main/pyproject.toml#L30

@stevenbal
Copy link
Collaborator

Looks good, though I think you merged master to your branch and then rebased? Because the commit message is now the same as the latest merge commit on master. Could you fix the message with git commit --amend to revert to your previous message (e.g ✨ [#155] replaced base.in libs with open-api-framework)?

@bart-maykin bart-maykin force-pushed the feature/155-open-api-framework branch from 901d8dc to 2f385ad Compare April 23, 2024 13:41
@stevenbal stevenbal merged commit c391829 into master Apr 25, 2024
12 checks passed
@stevenbal stevenbal deleted the feature/155-open-api-framework branch April 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Open Api Framework metapackage
3 participants