✨ [#183] added afgehandeld_op field for internetaken #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-maykin
force-pushed
the
feature/183-internetaak-afgehandeld
branch
from
3257edc
to
d02cf9b
Compare
stevenbal
requested changes
Apr 26, 2024
src/openklant/components/klantinteracties/admin/internetaken.py
Outdated
Show resolved
Hide resolved
src/openklant/components/klantinteracties/api/serializers/internetaken.py
Outdated
Show resolved
Hide resolved
src/openklant/components/klantinteracties/api/serializers/internetaken.py
Outdated
Show resolved
Hide resolved
|
|
||
| validated_data["actor"] = Actor.objects.get(uuid=actor_uuid) | ||
| validated_data["klantcontact"] = Klantcontact.objects.get( | ||
| uuid=klantcontact_uuid | ||
| ) | ||
|
|
||
| if validated_data.get("status") == Taakstatus.verwerkt: | ||
| validated_data["afgehandeld_op"] = afgehandeld_op |
There was a problem hiding this comment.
Is it necessary to implement this in the serializer .create and .update? I think it would be easier to implement it in the InterneTaak model .save.
I think since afgehandeldOp is a field for which the value is always now() or None, it should probably be a read-only field on the serializer, that way you can remove the .validate and the changes in .create and .update and leave the logic in InterneTaak.save as is
There was a problem hiding this comment.
Voor afgehandeldOp we want the user to either provide a value or user the date when the request was made. Hence why we shouldn't set the field as read_only. We can definitely set the value if none provided in the model .save method.
bart-maykin
force-pushed
the
feature/183-internetaak-afgehandeld
branch
from
2384355
to
2199b1a
Compare
Coperh
approved these changes
May 3, 2024
src/openklant/components/klantinteracties/models/internetaken.py
Outdated
Show resolved
Hide resolved
src/openklant/components/klantinteracties/api/serializers/internetaken.py
Outdated
Show resolved
Hide resolved
stevenbal
approved these changes
May 7, 2024
…ore precise in checking for status
bart-maykin
force-pushed
the
feature/183-internetaak-afgehandeld
branch
from
d9ff5ca
to
2a0483e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
afgehandeld_opfield forinternetakenafgehandeld_opwhen status is set onverwerktafgehandeld_opwhen status is set back onte_verwerkenifafgehandeld_opalready had a date