Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Streamline environment variables #187

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented Apr 26, 2024

issue: open-zaak/open-zaak#1629

Changes

  • 🔥 Remove unused sniplates template
  • 🔧 Add missing DEFAULT_FROM_EMAIL envvar
  • 🔧 Add missing CACHE_OIDC envvar
  • 🔧 Remove DB_ENGINE envvar
  • 🔧 Add missing Django CORS headers settings
  • 🔧 Bring logging settings in line with Open Zaak
  • 🔧 Bring Elastic APM settings in line with Open Zaak/Open Notificaties
  • 🔧 Add USE_X_FORWARDED_HOST setting
  • 🔧 Replace os.getenv with config

@stevenbal stevenbal marked this pull request as draft April 26, 2024 11:04
@stevenbal stevenbal changed the title 🔧 Replace os.getenv with config 🔧 Streamline environment variables Apr 26, 2024
* 🔧 Replace os.getenv with config
* 🔧 Add USE_X_FORWARDED_HOST setting
* 🔧 Bring Elastic APM settings in line with Open Zaak/Open Notificaties
* 🔧 Bring logging settings in line with Open Zaak
* 🔧 Add missing Django CORS headers settings
* 🔧 Remove DB_ENGINE envvar
* 🔧 Add missing CACHE_OIDC envvar
* 🔧 Add missing DEFAULT_FROM_EMAIL envvar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make an issue to remove it from our default project?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a minor question.

src/openklant/conf/base.py Show resolved Hide resolved
@stevenbal stevenbal merged commit 00b8d28 into master May 17, 2024
15 checks passed
@stevenbal stevenbal deleted the feature/streamline-envvars branch May 17, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants