-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Streamline environment variables #187
Conversation
6cd51f7
to
01ca45e
Compare
* 🔧 Replace os.getenv with config * 🔧 Add USE_X_FORWARDED_HOST setting * 🔧 Bring Elastic APM settings in line with Open Zaak/Open Notificaties * 🔧 Bring logging settings in line with Open Zaak * 🔧 Add missing Django CORS headers settings * 🔧 Remove DB_ENGINE envvar * 🔧 Add missing CACHE_OIDC envvar * 🔧 Add missing DEFAULT_FROM_EMAIL envvar
01ca45e
to
2931801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make an issue to remove it from our default project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just a minor question.
issue: open-zaak/open-zaak#1629
Changes