Feature/189 install maykin 2fa #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coperh
force-pushed
the
feature/189-install-maykin-2fa
branch
from
1e3232b
to
699d5bc
Compare
|
Requires maykinmedia/open-api-framework#27 to be merged and released |
|
Requires maykinmedia/open-api-framework#31 to be merged and released. |
|
Waiting for Other PR #190 to merge Merge Complete |
Coperh
force-pushed
the
feature/189-install-maykin-2fa
branch
from
64f0563
to
f2f4b03
Compare
Coperh
force-pushed
the
feature/189-install-maykin-2fa
branch
from
f2f4b03
to
056fbab
Compare
Coperh
commented
Jul 2, 2024
stevenbal
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Works as expected, could you also add DISABLE_2FA to the docker-compose envvars (with default True)?
I do notice that some templates show the admin version though, these should not be visible until the user is fully authenticated
after adding 2FA:
backuptokens template:
I think this can be fixed by overriding the base template footer: https://github.com/open-zaak/open-zaak/blob/main/src/openzaak/templates/maykin_2fa/base.html
Coperh
force-pushed
the
feature/189-install-maykin-2fa
branch
from
ff87eed
to
3c73226
Compare
stevenbal
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189