Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Release 2.1.0 #201

Merged
merged 1 commit into from
Jul 16, 2024
Merged

🔖 Release 2.1.0 #201

merged 1 commit into from
Jul 16, 2024

Conversation

Coperh
Copy link
Contributor

@Coperh Coperh commented Jul 5, 2024

Fixes #198

Anything missing from the changelog?

.bumpversion.cfg Show resolved Hide resolved
@Coperh
Copy link
Contributor Author

Coperh commented Jul 5, 2024

I also do want #199 merged before release.

@Coperh
Copy link
Contributor Author

Coperh commented Jul 10, 2024

@stevenbal @bart-maykin do you guys see anything missing from the change list or bad change descriptions or is everything A-OK?

Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #183 is missing from the changelog

@Coperh Coperh force-pushed the release/2.1.0 branch 2 times, most recently from 6e30f76 to 12ce549 Compare July 12, 2024 08:34
@Coperh Coperh requested a review from stevenbal July 12, 2024 08:35
@Coperh
Copy link
Contributor Author

Coperh commented Jul 12, 2024

Does open-klant not have documentation?

@annashamray
Copy link
Contributor

@Coperh You mean RTD?

@Coperh
Copy link
Contributor Author

Coperh commented Jul 12, 2024

@annashamray Yes

@annashamray
Copy link
Contributor

Good question! @bart-maykin Do you know something?

@stevenbal
Copy link
Collaborator

@Coperh there is a RTD apparently: https://open-klant.readthedocs.io/en/latest/, not much in it yet though

@Coperh Coperh merged commit ba752ea into master Jul 16, 2024
15 checks passed
@Coperh Coperh deleted the release/2.1.0 branch July 16, 2024 09:39
@joeribekker
Copy link
Member

@Coperh sorry to join the party late, but I see that 2 people approved this PR but I see something in the README that caught my eye:

The 2.0.0 was changed to 2.1.0. This is not correct imo.

There should be an entry with 2.0.0, showing it offered API version 0.0.3. There should be another entry showing 2.1.0 offers 0.0.3+ since it contains an experimental field. This field in the changelog is shown as afgehandeld_op, but should show afgehandeldOp which is how the API spec works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release a new patch/minor version of Open Klant
4 participants