🐛[#226] make digitalAdres betrokkene optional in admin #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
approved these changes
Oct 24, 2024
stevenbal
reviewed
Oct 24, 2024
Comment on lines
+117
to
+119
| add_dynamic_field(form, "digitaaladres_set-0-omschrijving", "description") | ||
| add_dynamic_field(form, "digitaaladres_set-0-soort_digitaal_adres", "email") | ||
| add_dynamic_field(form, "digitaaladres_set-0-adres", "[email protected]") |
There was a problem hiding this comment.
As an alternative to having to add these fields, you could maybe create a DigitaalAdres with a factory to ensure the form is there, and then try to save it again without a betrokkene, but either way is fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226