Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[#261] change Onderwerpobject inline to use klantcontact #275

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Coperh
Copy link
Contributor

@Coperh Coperh commented Nov 1, 2024

Fixes #261

@Coperh Coperh requested a review from stevenbal November 1, 2024 12:00
@Coperh
Copy link
Contributor Author

Coperh commented Nov 1, 2024

I'd say the klantcontact relation is more correct since its a required field.
Maybe keep was_klantcontact but make it read-only?

It does duplicate inline if both klantcontact and was_klantcontact are set to the same klantcontact.

@Coperh
Copy link
Contributor Author

Coperh commented Nov 1, 2024

Also I do not think you cam filter on klantcontact on the onderwerpobject endpoint

@stevenbal
Copy link
Collaborator

@Coperh I think the change you made is correct. I don't think it will happen in practice that both klantcontact and was_klantcontact point to the same KlantContact instance

@Coperh Coperh merged commit f8930d5 into master Nov 8, 2024
17 checks passed
@Coperh Coperh deleted the feature/261-onderwerpobjecten-inline-fix branch November 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Klantcontact.onderwerpobjecten inline does not show related onderwerpobjecten
2 participants