Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [#967] fixed bug that wouldn't clear toelichting field #968

Merged
merged 2 commits into from
Aug 25, 2023
Merged

🐛 [#967] fixed bug that wouldn't clear toelichting field #968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78d82c7
:bug: [#967] fixed bug that wouldn't clear toelichting field
bart-maykin Aug 18, 2023
8c353a4
:card_file_box: [#967] added datamigration to delete product_aanwezig…
bart-maykin Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 12 additions & 27 deletions src/sdg/js/components/generic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,13 @@ class GenericForm {
this.collapseExpand()
}

emptyFieldValues(fields) {
fields.forEach((item) => {
const textarea = item.querySelector("textarea");
textarea.value = ""
})
async emptyFieldValues(fields) {
if (await fields === []) {
fields.forEach((item) => {
const textarea = item.querySelector("textarea");
textarea.value = "";
})
}
}

async getProductTranslationName(productId, language) {
Expand All @@ -84,7 +86,6 @@ class GenericForm {
.then(data => data.results[0])

if (translationJsonResults) {

if (translationJsonResults.productTitel) {
return translationJsonResults.productTitel
}
Expand Down Expand Up @@ -141,9 +142,8 @@ class GenericForm {
let previousIndex = input.selectedIndex;

const displayFunc = async (displayDependency) => {
const controls = await displayDependency.querySelectorAll(".form__control")
if (input.selectedIndex === 2) {
const controls = displayDependency.querySelectorAll(".form__control")

if (input.selectedIndex != previousIndex) {
if (confirm("Weet u zeker dat u dit product niet aanbiedt?\nAls u 'OK' antwoordt worden alle teksten leeggemaakt.")) {
this.resetSpecefiekeGegevens();
Expand All @@ -163,25 +163,10 @@ class GenericForm {
}
});
} else {
const controls = displayDependency.querySelectorAll(".form__control")
let emptyOrDefault = 0
controls.forEach((element, index, array) => {
const textarea = element.querySelector("textarea");
const defaultExplanation = document.querySelector(`.form__reference-${element.lang}`).dataset.productAanwezigToelichting;

if (!textarea.value || textarea.value === defaultExplanation) {
emptyOrDefault += 1
}

if (emptyOrDefault == 2) {
this.displayHidden(dependency, "aanwezig")
this.emptyFieldValues([array[index - 1], element])
previousIndex = 0;
return
}

this.displayBlock(dependency, "aanwezig")
})
controls.forEach(async (fields) => {
this.displayHidden(dependency, "aanwezig");
this.emptyFieldValues(fields);
});
};

previousIndex = input.selectedIndex;
Expand Down
Loading