Cleanup + move some common functionality from platform build scripts into this plugin #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexanderpann, please split this PR into smaller, focused PRs to simplify review. |
|
In general, conventions and utilities that are specific to the way that itemis libraries are being built should go into a separate Gradle plugin. It may be part of this repository but should probably have its own subproject because it may end up having different dependencies. |
sergej-koscejev
requested changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many lines of code always repeat in our build scripts. I exposed a few new methods through extensions and also cleaned up a few things that I found. Please let me know what you think about the changes, as I am not a Gradle expert. I can remove unwanted commits.
For the example build script, the length changes from 294 lines to 187:
https://gist.github.com/alexanderpann/67cc16888f425560990edc2b3f408654