Parametrize HasRateLimitStrategy by key #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
approved these changes
Jun 7, 2022
hasufell
commented
Jun 7, 2022
|
I have fixed the commit that was wrong. Sorry about that. Can you rebase this on |
hasufell
force-pushed
the
PR/hasufell/parametrize-key
branch
from
d7c93cd to
a823fbc
Compare
|
I think the CI failure is some flakiness unrelated to your changes. I will merge it. Thank you for opening the issue about this on Friday to let me know that this was an issue for you and thanks for making the changes here! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6 (comment)